From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, sfr@canb.auug.org.au,
linux-next@vger.kernel.org
Subject: Re: [PATCH] ath6kl: fix function name conflicts with ath9k
Date: Wed, 10 Aug 2011 10:24:23 +0300 [thread overview]
Message-ID: <4E423227.2070404@qca.qualcomm.com> (raw)
In-Reply-To: <1312960312-7884-1-git-send-email-kvalo@qca.qualcomm.com>
On 08/10/2011 10:11 AM, Kalle Valo wrote:
> Stepher reported that compilation fails if both ath6kl and ath9k are
> compiled in:
>
> drivers/net/wireless/ath/ath6kl/built-in.o: In function `htc_start':
> (.opd+0x600): multiple definition of `htc_start'
> drivers/net/wireless/ath/ath9k/built-in.o:(.opd+0x3e40): first defined here
> drivers/net/wireless/ath/ath6kl/built-in.o: In function `.htc_stop':
> (.text+0x7b40): multiple definition of `.htc_stop'
> drivers/net/wireless/ath/ath9k/built-in.o:(.text+0x67b34): first defined he=
> re
> drivers/net/wireless/ath/ath6kl/built-in.o: In function `.htc_start':
> (.text+0x7d18): multiple definition of `.htc_start'
> drivers/net/wireless/ath/ath9k/built-in.o:(.text+0x67ba0): first defined he=
> re
> drivers/net/wireless/ath/ath6kl/built-in.o: In function `htc_stop':
> (.opd+0x5e8): multiple definition of `htc_stop'
> drivers/net/wireless/ath/ath9k/built-in.o:(.opd+0x3e28): first defined here
>
> To fix this add ath6kl prefix to all public functions in htc.c.
I have applied this to the ath6kl tree now:
http://git.kernel.org/?p=linux/kernel/git/kvalo/ath6kl.git;a=summary
I'll send a pull request to John later today.
Kalle
prev parent reply other threads:[~2011-08-10 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 2:21 linux-next: build failure after merge of the final tree (wireless tree related) Stephen Rothwell
2011-08-10 6:11 ` Kalle Valo
[not found] ` <20110810122109.a81b3186e4131aba82a4cae0-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2011-08-10 7:11 ` [PATCH] ath6kl: fix function name conflicts with ath9k Kalle Valo
2011-08-10 7:24 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E423227.2070404@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).