From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen) Date: Wed, 10 Aug 2011 09:49:59 -0700 Message-ID: <4E42B6B7.6090709@goop.org> References: <20110725162542.39ea8d8cbd51604523635c1a@canb.auug.org.au> <20110725144629.b752bf14.rdunlap@xenotime.net> <20110804193534.GB12729@elte.hu> <20110804195539.GA11198@dumpdata.com> <20110804131516.c4da6595.rdunlap@xenotime.net> <20110804223259.GB4370@dumpdata.com> <20110804224020.GA21492@dumpdata.com> <4E3B3117.5050308@xenotime.net> <20110805080531.GA8052@elte.hu> <20110805211423.GA9765@elte.hu> <20110806015815.GA26833@dumpdata.com> <4E3D8657.7000704@goop.org> <1312808467.18583.223.camel@gandalf.stny.rr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from claw.goop.org ([74.207.240.146]:59726 "EHLO claw.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752361Ab1HJQuI (ORCPT ); Wed, 10 Aug 2011 12:50:08 -0400 In-Reply-To: <1312808467.18583.223.camel@gandalf.stny.rr.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Steven Rostedt Cc: Konrad Rzeszutek Wilk , Ingo Molnar , Stephen Rothwell , xen-devel@lists.xensource.com, LKML , virtualization@lists.linux-foundation.org, Jeremy Fitzhardinge , linux-next@vger.kernel.org, "H. Peter Anvin" , Andrew Morton , Linus Torvalds , Thomas Gleixner On 08/08/2011 06:01 AM, Steven Rostedt wrote: > On Sat, 2011-08-06 at 11:22 -0700, Jeremy Fitzhardinge wrote: >> On 08/05/2011 06:58 PM, Konrad Rzeszutek Wilk wrote: >>> On Fri, Aug 05, 2011 at 11:14:23PM +0200, Ingo Molnar wrote: >>>> * Ingo Molnar wrote: >>>> >>>>> * Randy Dunlap wrote: >>>>> >>>>>> On 08/04/11 15:40, Konrad Rzeszutek Wilk wrote: >>>>>>> On Thu, Aug 04, 2011 at 06:32:59PM -0400, Konrad Rzeszutek Wilk= wrote: >>>>>>>>>>> These build failures are still triggering upstream: >>>>>>>>>>> >>>>>>>>>>> arch/x86/xen/trace.c:44:2: error: array index in initializ= er not of integer type >>>>>>>>>>> arch/x86/xen/trace.c:44:2: error: (near initialization for= =E2=80=98xen_hypercall_names=E2=80=99) >>>>>>>>>>> arch/x86/xen/trace.c:45:1: error: =E2=80=98__HYPERVISOR_ar= ch_4=E2=80=99 undeclared here (not in a function) >>>>>>>>>>> arch/x86/xen/trace.c:45:2: error: array index in initializ= er not of integer type >>>>>>>>>>> arch/x86/xen/trace.c:45:2: error: (near initialization for= =E2=80=98xen_hypercall_names=E2=80=99) >>>>>>>>>> Oh, that I haven't seen. Can you send me the .config for tha= t please. >>>>>>>>> You can't be trying very hard then. I see lots of these (but= no, >>>>>>>> Ah, I am getting it now. Thanks for reporting it. >>>>>>> This should do the trick: >>>>>> Acked-by: Randy Dunlap >>>>> That patch did the trick here too: >>>>> >>>>> Acked-by: Ingo Molnar >>>> Except that i'm still seeing the occasional build failure - see th= e=20 >>>> error log below. Config attached. >>> Much appreciate for the report. I believe this fix (which I think h= it >>> linux-next yesterday?) should do that: >>> >>> commit 1e9ea2656b656edd3c8de98675bbc0340211b5bd >>> Author: Jeremy Fitzhardinge >>> Date: Wed Aug 3 09:43:44 2011 -0700 >>> >>> xen/tracing: it looks like we wanted CONFIG_FTRACE >>> =20 >>> Apparently we wanted CONFIG_FTRACE rather the CONFIG_FUNCTION_T= RACER. >>> =20 >>> Reported-by: Sander Eikelenboom >>> Tested-by: Sander Eikelenboom >>> Signed-off-by: Jeremy Fitzhardinge >>> Signed-off-by: Konrad Rzeszutek Wilk >>> >>> diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile >>> index 45e94ac..3326204 100644 >>> --- a/arch/x86/xen/Makefile >>> +++ b/arch/x86/xen/Makefile >>> @@ -15,7 +15,7 @@ obj-y :=3D enlighten.o setup.o multicalls.o mmu.= o irq.o \ >>> grant-table.o suspend.o platform-pci-unplug.o \ >>> p2m.o >>> =20 >>> -obj-$(CONFIG_FUNCTION_TRACER) +=3D trace.o >>> +obj-$(CONFIG_FTRACE) +=3D trace.o >>> =20 >> I'm not sure this is correct either. Maybe it should be >> CONFIG_TRACEPOINTS? Steven? > Actually, I believe the correct answer is: > > CONFIG_EVENT_TRACING OK, thanks. J