From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Anand Gadiyar <gadiyar@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH linux-next] mfd: omap-usb-host: add module.h and export.h to fix build break
Date: Fri, 19 Aug 2011 11:48:17 -0400 [thread overview]
Message-ID: <4E4E85C1.9060405@windriver.com> (raw)
In-Reply-To: <1313767445-20033-1-git-send-email-gadiyar@ti.com>
On 11-08-19 11:24 AM, Anand Gadiyar wrote:
> linux-next as of 20110817 fails to build if these two headers
> are not included. Including module.h is sufficient for now,
> but add export.h for EXPORT_SYMBOL and THIS_MODULE in advance
> to avoid a later build break.
Thanks -- We won't need to add both, since module.h will source
the export.h itself. And we can't add export.h to mainline just
yet, since it won't exist there (it is only in linux-next now.)
I'll just add the right one to this file in the existing mtd patch.
Thanks for the report.
Paul.
>
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> ---
> Noticed this while testing another patch. I see similar
> changes to other files in drivers/mfd made by Paul recently.
>
> drivers/mfd/omap-usb-host.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: linux-2.6/drivers/mfd/omap-usb-host.c
> ===================================================================
> --- linux-2.6.orig/drivers/mfd/omap-usb-host.c
> +++ linux-2.6/drivers/mfd/omap-usb-host.c
> @@ -20,6 +20,8 @@
> #include <linux/types.h>
> #include <linux/slab.h>
> #include <linux/delay.h>
> +#include <linux/export.h>
> +#include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/clk.h>
> #include <linux/dma-mapping.h>
next prev parent reply other threads:[~2011-08-19 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 15:24 [PATCH linux-next] mfd: omap-usb-host: add module.h and export.h to fix build break Anand Gadiyar
2011-08-19 15:48 ` Paul Gortmaker [this message]
2011-08-22 15:06 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4E85C1.9060405@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=gadiyar@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).