From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Gortmaker Subject: Re: [PATCH linux-next] mfd: omap-usb-host: add module.h and export.h to fix build break Date: Fri, 19 Aug 2011 11:48:17 -0400 Message-ID: <4E4E85C1.9060405@windriver.com> References: <1313767445-20033-1-git-send-email-gadiyar@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.windriver.com ([147.11.1.11]:45562 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754825Ab1HSPsc (ORCPT ); Fri, 19 Aug 2011 11:48:32 -0400 In-Reply-To: <1313767445-20033-1-git-send-email-gadiyar@ti.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Anand Gadiyar Cc: linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, Samuel Ortiz On 11-08-19 11:24 AM, Anand Gadiyar wrote: > linux-next as of 20110817 fails to build if these two headers > are not included. Including module.h is sufficient for now, > but add export.h for EXPORT_SYMBOL and THIS_MODULE in advance > to avoid a later build break. Thanks -- We won't need to add both, since module.h will source the export.h itself. And we can't add export.h to mainline just yet, since it won't exist there (it is only in linux-next now.) I'll just add the right one to this file in the existing mtd patch. Thanks for the report. Paul. > > Signed-off-by: Anand Gadiyar > Cc: Paul Gortmaker > Cc: Samuel Ortiz > --- > Noticed this while testing another patch. I see similar > changes to other files in drivers/mfd made by Paul recently. > > drivers/mfd/omap-usb-host.c | 2 ++ > 1 file changed, 2 insertions(+) > > Index: linux-2.6/drivers/mfd/omap-usb-host.c > =================================================================== > --- linux-2.6.orig/drivers/mfd/omap-usb-host.c > +++ linux-2.6/drivers/mfd/omap-usb-host.c > @@ -20,6 +20,8 @@ > #include > #include > #include > +#include > +#include > #include > #include > #include