From: Timur Tabi <timur@freescale.com>
To: Greg KH <greg@kroah.com>
Cc: sfr@canb.auug.org.au, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] tty/powerpc: fix build break with ehv_bytechan.c on allyesconfig
Date: Thu, 25 Aug 2011 13:51:20 -0500 [thread overview]
Message-ID: <4E5699A8.1070708@freescale.com> (raw)
In-Reply-To: <20110825184655.GB1891@kroah.com>
Greg KH wrote:
> But don't you really want this type of check at runtime? What happens
> if you load this driver on a machine that is not a guest? Will things
> break? Shouldn't you still refuse to load somehow?
This is in the udbg code, which falls under the category of, "turn this on only
if you know what you're doing."
The udbg code runs very early, before the device tree is available. There's no
way of knowing at this point whether or not we're running under a hypervisor.
If you turn on udbg support, then it means that you're trying to do some very
specific debugging on a specific platform.
So I'm not removing this code just to fix the build break. It really should
never have been there in the first place.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-08-25 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 16:20 [PATCH] tty/powerpc: fix build break with ehv_bytechan.c on allyesconfig Timur Tabi
2011-08-25 16:32 ` Greg KH
2011-08-25 18:02 ` Timur Tabi
2011-08-25 18:46 ` Greg KH
2011-08-25 18:51 ` Timur Tabi [this message]
2011-08-25 19:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5699A8.1070708@freescale.com \
--to=timur@freescale.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).