From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH -next v2] bcma: driver_chipcommon_pmu.c needs linux/export.h Date: Wed, 21 Sep 2011 08:52:44 -0700 Message-ID: <4E7A084C.3000304@xenotime.net> References: <20110920173102.d38155c7defbbc29beaae7c0@canb.auug.org.au> <4E78CFC0.4020003@xenotime.net> <4E78FCDB.1010002@xenotime.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from oproxy6-pub.bluehost.com ([67.222.54.6]:40714 "HELO oproxy6-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752392Ab1IUPwq (ORCPT ); Wed, 21 Sep 2011 11:52:46 -0400 In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Andrew Morton , Stephen Rothwell , linux-next@vger.kernel.org, LKML , "linux-wireless@vger.kernel.org" On 09/20/2011 11:45 PM, Rafa=C5=82 Mi=C5=82ecki wrote: > W dniu 20 wrze=C5=9Bnia 2011 22:51 u=C5=BCytkownik Randy Dunlap > napisa=C5=82: >> From: Randy Dunlap >> >> bcma/driver_chipcommon_pmu.c needs to include >> to fix these warnings: >> >> drivers/bcma/driver_chipcommon_pmu.c:27:1: warning: data definition = has no type or storage class >> drivers/bcma/driver_chipcommon_pmu.c:27:1: warning: type defaults to= 'int' in declaration of 'EXPORT_SYMBOL_GPL' >> drivers/bcma/driver_chipcommon_pmu.c:27:1: warning: parameter names = (without types) in function declaration >=20 > Don't you get the same warning for core.c? Weird... No, I don't. Stranger things have happened, I'm sure. =46eel free to add export.h to other files, or do you want me to do that? --=20 ~Randy *** Remember to use Documentation/SubmitChecklist when testing your cod= e ***