* [PATCH -next] qdio: add missing export.h include
@ 2011-09-22 7:21 Heiko Carstens
2011-09-27 22:17 ` Paul Gortmaker
2011-09-27 22:33 ` Paul Gortmaker
0 siblings, 2 replies; 6+ messages in thread
From: Heiko Carstens @ 2011-09-22 7:21 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linux-next, Heiko Carstens, Frank Blaschka, Jan Glauber
Fix compile breakage caused by splitting module.h:
drivers/s390/cio/qdio_setup.c:31:1:
warning: data definition has no type or storage class [enabled by default]
drivers/s390/cio/qdio_setup.c:31:1:
warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int]
Cc: Frank Blaschka <blaschka@linux.vnet.ibm.com>
Cc: Jan Glauber <jang@linux.vnet.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
drivers/s390/cio/qdio_setup.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/s390/cio/qdio_setup.c b/drivers/s390/cio/qdio_setup.c
index d9a46a4..25f4988 100644
--- a/drivers/s390/cio/qdio_setup.c
+++ b/drivers/s390/cio/qdio_setup.c
@@ -7,6 +7,7 @@
* Author(s): Jan Glauber <jang@linux.vnet.ibm.com>
*/
#include <linux/kernel.h>
+#include <linux/export.h>
#include <linux/slab.h>
#include <asm/qdio.h>
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next] qdio: add missing export.h include
2011-09-22 7:21 [PATCH -next] qdio: add missing export.h include Heiko Carstens
@ 2011-09-27 22:17 ` Paul Gortmaker
2011-09-27 22:33 ` Paul Gortmaker
1 sibling, 0 replies; 6+ messages in thread
From: Paul Gortmaker @ 2011-09-27 22:17 UTC (permalink / raw)
To: Heiko Carstens; +Cc: linux-next, Frank Blaschka, Jan Glauber
On 11-09-22 03:21 AM, Heiko Carstens wrote:
> Fix compile breakage caused by splitting module.h:
>
> drivers/s390/cio/qdio_setup.c:31:1:
> warning: data definition has no type or storage class [enabled by default]
> drivers/s390/cio/qdio_setup.c:31:1:
> warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int]
Thanks, I've squashed this into what contained the other
s390 changes from you, which now touches the following:
arch/s390/crypto/sha_common.c | 1 +
arch/s390/mm/init.c | 1 +
drivers/s390/char/fs3270.c | 1 +
drivers/s390/char/sclp_cpi_sys.c | 1 +
drivers/s390/char/vmcp.c | 1 +
drivers/s390/char/vmur.c | 1 +
drivers/s390/cio/chp.c | 2 ++
drivers/s390/cio/qdio_debug.c | 2 ++
drivers/s390/cio/qdio_setup.c | 1 +
drivers/s390/kvm/kvm_virtio.c | 1 +
drivers/s390/scsi/zfcp_aux.c | 1 +
drivers/s390/scsi/zfcp_ccw.c | 1 +
drivers/s390/scsi/zfcp_dbf.c | 1 +
drivers/s390/scsi/zfcp_scsi.c | 1 +
14 files changed, 16 insertions(+)
Paul.
>
> Cc: Frank Blaschka <blaschka@linux.vnet.ibm.com>
> Cc: Jan Glauber <jang@linux.vnet.ibm.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
> drivers/s390/cio/qdio_setup.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/s390/cio/qdio_setup.c b/drivers/s390/cio/qdio_setup.c
> index d9a46a4..25f4988 100644
> --- a/drivers/s390/cio/qdio_setup.c
> +++ b/drivers/s390/cio/qdio_setup.c
> @@ -7,6 +7,7 @@
> * Author(s): Jan Glauber <jang@linux.vnet.ibm.com>
> */
> #include <linux/kernel.h>
> +#include <linux/export.h>
> #include <linux/slab.h>
> #include <asm/qdio.h>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] qdio: add missing export.h include
2011-09-22 7:21 [PATCH -next] qdio: add missing export.h include Heiko Carstens
2011-09-27 22:17 ` Paul Gortmaker
@ 2011-09-27 22:33 ` Paul Gortmaker
2011-09-28 4:54 ` Stephen Rothwell
2011-09-28 6:34 ` Heiko Carstens
1 sibling, 2 replies; 6+ messages in thread
From: Paul Gortmaker @ 2011-09-27 22:33 UTC (permalink / raw)
To: Heiko Carstens; +Cc: linux-next, Frank Blaschka, Jan Glauber
On 11-09-22 03:21 AM, Heiko Carstens wrote:
> Fix compile breakage caused by splitting module.h:
>
> drivers/s390/cio/qdio_setup.c:31:1:
> warning: data definition has no type or storage class [enabled by default]
> drivers/s390/cio/qdio_setup.c:31:1:
> warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int]
Now that I look at this, and the other patch, I'm not
seeing how this is possible. Unless there is some
convoluted CPP magic going on, I don't see any instances
of EXPORT_SYMBOL in qdio_setup.c -- similarly I don't
see any module_ or MODULE_ references in zfcp_qdio.c
Am I missing something obvious here? The line numbers
you quote dont match anything meaningful -- so I'm wondering
if perhaps these changes are meant to be in advance of the
s390 changes you've got queued in next -- which is fine, but
it would be nice to have that called out.
Thanks,
Paul.
>
> Cc: Frank Blaschka <blaschka@linux.vnet.ibm.com>
> Cc: Jan Glauber <jang@linux.vnet.ibm.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
> drivers/s390/cio/qdio_setup.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/s390/cio/qdio_setup.c b/drivers/s390/cio/qdio_setup.c
> index d9a46a4..25f4988 100644
> --- a/drivers/s390/cio/qdio_setup.c
> +++ b/drivers/s390/cio/qdio_setup.c
> @@ -7,6 +7,7 @@
> * Author(s): Jan Glauber <jang@linux.vnet.ibm.com>
> */
> #include <linux/kernel.h>
> +#include <linux/export.h>
> #include <linux/slab.h>
> #include <asm/qdio.h>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] qdio: add missing export.h include
2011-09-27 22:33 ` Paul Gortmaker
@ 2011-09-28 4:54 ` Stephen Rothwell
2011-09-28 6:34 ` Heiko Carstens
1 sibling, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2011-09-28 4:54 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: Heiko Carstens, linux-next, Frank Blaschka, Jan Glauber
[-- Attachment #1: Type: text/plain, Size: 896 bytes --]
Hi Paul,
On Tue, 27 Sep 2011 18:33:30 -0400 Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
>
> Now that I look at this, and the other patch, I'm not
> seeing how this is possible. Unless there is some
> convoluted CPP magic going on, I don't see any instances
> of EXPORT_SYMBOL in qdio_setup.c -- similarly I don't
> see any module_ or MODULE_ references in zfcp_qdio.c
>
> Am I missing something obvious here? The line numbers
> you quote dont match anything meaningful -- so I'm wondering
> if perhaps these changes are meant to be in advance of the
> s390 changes you've got queued in next -- which is fine, but
> it would be nice to have that called out.
There is a patch in the net tree in linux-next that adds two
EXPORT_SYMBOL_GPLs to qdio_setup.c.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] qdio: add missing export.h include
2011-09-27 22:33 ` Paul Gortmaker
2011-09-28 4:54 ` Stephen Rothwell
@ 2011-09-28 6:34 ` Heiko Carstens
2011-09-28 14:03 ` Paul Gortmaker
1 sibling, 1 reply; 6+ messages in thread
From: Heiko Carstens @ 2011-09-28 6:34 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linux-next, Frank Blaschka, Jan Glauber
On Tue, Sep 27, 2011 at 06:33:30PM -0400, Paul Gortmaker wrote:
> On 11-09-22 03:21 AM, Heiko Carstens wrote:
> > Fix compile breakage caused by splitting module.h:
> >
> > drivers/s390/cio/qdio_setup.c:31:1:
> > warning: data definition has no type or storage class [enabled by default]
> > drivers/s390/cio/qdio_setup.c:31:1:
> > warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int]
>
> Now that I look at this, and the other patch, I'm not
> seeing how this is possible. Unless there is some
> convoluted CPP magic going on, I don't see any instances
> of EXPORT_SYMBOL in qdio_setup.c -- similarly I don't
> see any module_ or MODULE_ references in zfcp_qdio.c
>
> Am I missing something obvious here? The line numbers
> you quote dont match anything meaningful -- so I'm wondering
> if perhaps these changes are meant to be in advance of the
> s390 changes you've got queued in next -- which is fine, but
> it would be nice to have that called out.
Oh right, I should have mentioned this. Sorry!
he two patches fix compile breakages only in -next because of s390
related patches in the scsi and net git trees. Since it's not possible
to add the compile fixes (at least for the new export.h header file)
to the scsi or net trees I just sent these patches towards you...
Thanks,
Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] qdio: add missing export.h include
2011-09-28 6:34 ` Heiko Carstens
@ 2011-09-28 14:03 ` Paul Gortmaker
0 siblings, 0 replies; 6+ messages in thread
From: Paul Gortmaker @ 2011-09-28 14:03 UTC (permalink / raw)
To: Heiko Carstens; +Cc: linux-next, Frank Blaschka, Jan Glauber
On 11-09-28 02:34 AM, Heiko Carstens wrote:
> On Tue, Sep 27, 2011 at 06:33:30PM -0400, Paul Gortmaker wrote:
>> On 11-09-22 03:21 AM, Heiko Carstens wrote:
>>> Fix compile breakage caused by splitting module.h:
>>>
>>> drivers/s390/cio/qdio_setup.c:31:1:
>>> warning: data definition has no type or storage class [enabled by default]
>>> drivers/s390/cio/qdio_setup.c:31:1:
>>> warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int]
>>
>> Now that I look at this, and the other patch, I'm not
>> seeing how this is possible. Unless there is some
>> convoluted CPP magic going on, I don't see any instances
>> of EXPORT_SYMBOL in qdio_setup.c -- similarly I don't
>> see any module_ or MODULE_ references in zfcp_qdio.c
>>
>> Am I missing something obvious here? The line numbers
>> you quote dont match anything meaningful -- so I'm wondering
>> if perhaps these changes are meant to be in advance of the
>> s390 changes you've got queued in next -- which is fine, but
>> it would be nice to have that called out.
>
> Oh right, I should have mentioned this. Sorry!
> he two patches fix compile breakages only in -next because of s390
> related patches in the scsi and net git trees. Since it's not possible
> to add the compile fixes (at least for the new export.h header file)
> to the scsi or net trees I just sent these patches towards you...
OK, thanks for the info. I'll update the commit header with
a note indicating those two changes are in anticipation of
pending s390 changes.
Paul.
>
> Thanks,
> Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-09-28 14:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-22 7:21 [PATCH -next] qdio: add missing export.h include Heiko Carstens
2011-09-27 22:17 ` Paul Gortmaker
2011-09-27 22:33 ` Paul Gortmaker
2011-09-28 4:54 ` Stephen Rothwell
2011-09-28 6:34 ` Heiko Carstens
2011-09-28 14:03 ` Paul Gortmaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).