From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH] drivers/media: fix dependencies in video mt9t001/mt9p031 Date: Fri, 30 Sep 2011 15:38:13 -0700 Message-ID: <4E8644D5.6080307@xenotime.net> References: <4E83A02F.2020309@xenotime.net> <1317418491-26513-1-git-send-email-paul.gortmaker@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from oproxy8-pub.bluehost.com ([69.89.22.20]:54405 "HELO oproxy8-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1757466Ab1I3WiQ (ORCPT ); Fri, 30 Sep 2011 18:38:16 -0400 In-Reply-To: <1317418491-26513-1-git-send-email-paul.gortmaker@windriver.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Paul Gortmaker Cc: mchehab@redhat.com, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-media@vger.kernel.org On 09/30/11 14:34, Paul Gortmaker wrote: > Both mt9t001.c and mt9p031.c have two identical issues, those > being that they will need module.h inclusion for the upcoming > cleanup going on there, and that their dependencies don't limit > selection of configs that will fail to compile as follows: >=20 > drivers/media/video/mt9p031.c:457: error: implicit declaration of fun= ction =E2=80=98v4l2_subdev_get_try_crop=E2=80=99 > drivers/media/video/mt9t001.c:787: error: =E2=80=98struct v4l2_subdev= =E2=80=99 has no member named =E2=80=98entity=E2=80=99 >=20 > The related config options are CONFIG_MEDIA_CONTROLLER and > CONFIG_VIDEO_V4L2_SUBDEV_API. Looking at the code, it appears > that the driver was never intended to work without these enabled, > so add a dependency on CONFIG_VIDEO_V4L2_SUBDEV_API, which in > turn already has a dependency on CONFIG_MEDIA_CONTROLLER. >=20 > Reported-by: Randy Dunlap > Signed-off-by: Paul Gortmaker Acked-by: Randy Dunlap Thanks, Paul. >=20 > diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfi= g > index 75e43c0..d285c8c 100644 > --- a/drivers/media/video/Kconfig > +++ b/drivers/media/video/Kconfig > @@ -469,14 +469,14 @@ config VIDEO_OV7670 > =20 > config VIDEO_MT9P031 > tristate "Aptina MT9P031 support" > - depends on I2C && VIDEO_V4L2 > + depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API > ---help--- > This is a Video4Linux2 sensor-level driver for the Aptina > (Micron) mt9p031 5 Mpixel camera. > =20 > config VIDEO_MT9T001 > tristate "Aptina MT9T001 support" > - depends on I2C && VIDEO_V4L2 > + depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API > ---help--- > This is a Video4Linux2 sensor-level driver for the Aptina > (Micron) mt0t001 3 Mpixel camera. > diff --git a/drivers/media/video/mt9p031.c b/drivers/media/video/mt9p= 031.c > index 8bcb1ce..fc9603f 100644 > --- a/drivers/media/video/mt9p031.c > +++ b/drivers/media/video/mt9p031.c > @@ -14,6 +14,7 @@ > =20 > #include > #include > +#include > #include > #include > #include > diff --git a/drivers/media/video/mt9t001.c b/drivers/media/video/mt9t= 001.c > index ae75d82..280d01d 100644 > --- a/drivers/media/video/mt9t001.c > +++ b/drivers/media/video/mt9t001.c > @@ -13,6 +13,7 @@ > */ > =20 > #include > +#include > #include > #include > #include --=20 ~Randy *** Remember to use Documentation/SubmitChecklist when testing your cod= e ***