From: Randy Dunlap <rdunlap@xenotime.net>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Linus <torvalds@linux-foundation.org>, Greg KH <gregkh@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Lior Dotan <liodot@gmail.com>,
Christopher Harrer <charrer@alacritech.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>
Subject: Re: [PATCH -next] staging: slicoss depends on NET
Date: Thu, 17 Nov 2011 09:06:32 -0800 [thread overview]
Message-ID: <4EC53F18.2080303@xenotime.net> (raw)
In-Reply-To: <4EB067ED.60106@xenotime.net>
adding driver devel mailing list.
Greg- ping- there are a lot of staging patches that need to be merged.
On 11/01/2011 02:43 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> The slicoss driver uses network interfaces so it should depend
> on NET. Fixes the following build errors:
>
> ERROR: "eth_change_mtu" [drivers/staging/slicoss/slicoss.ko] undefined!
> ERROR: "eth_validate_addr" [drivers/staging/slicoss/slicoss.ko] undefined!
> ERROR: "register_netdev" [drivers/staging/slicoss/slicoss.ko] undefined!
> ERROR: "alloc_etherdev_mqs" [drivers/staging/slicoss/slicoss.ko] undefined!
> ERROR: "__netif_schedule" [drivers/staging/slicoss/slicoss.ko] undefined!
> ERROR: "netif_rx" [drivers/staging/slicoss/slicoss.ko] undefined!
> ERROR: "eth_type_trans" [drivers/staging/slicoss/slicoss.ko] undefined!
> ERROR: "skb_put" [drivers/staging/slicoss/slicoss.ko] undefined!
> ERROR: "skb_pull" [drivers/staging/slicoss/slicoss.ko] undefined!
> ERROR: "__alloc_skb" [drivers/staging/slicoss/slicoss.ko] undefined!
> ERROR: "free_netdev" [drivers/staging/slicoss/slicoss.ko] undefined!
> ERROR: "unregister_netdev" [drivers/staging/slicoss/slicoss.ko] undefined!
> ERROR: "consume_skb" [drivers/staging/slicoss/slicoss.ko] undefined!
> ERROR: "dev_kfree_skb_irq" [drivers/staging/slicoss/slicoss.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Lior Dotan <liodot@gmail.com>
> Cc: Christopher Harrer <charrer@alacritech.com>
> ---
> drivers/staging/slicoss/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- next-2011-1101.orig/drivers/staging/slicoss/Kconfig
> +++ next-2011-1101/drivers/staging/slicoss/Kconfig
> @@ -1,6 +1,6 @@
> config SLICOSS
> tristate "Alacritech Gigabit IS-NIC support"
> - depends on PCI && X86
> + depends on PCI && X86 && NET
> default n
> help
> This driver supports Alacritech's IS-NIC gigabit ethernet cards.
> --
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-11-17 17:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 9:53 linux-next: Tree for Nov 1 Stephen Rothwell
2011-11-01 21:43 ` [PATCH -next] staging: slicoss depends on NET Randy Dunlap
2011-11-17 17:06 ` Randy Dunlap [this message]
2011-11-17 17:42 ` Greg KH
2011-11-01 21:53 ` [PATCH -next] platform/X86: fix dell-laptop function prototypes Randy Dunlap
2011-11-01 23:32 ` [PATCH -next] ext4: fix printk format warning in page-io Randy Dunlap
2011-11-02 1:59 ` Ted Ts'o
2011-11-01 23:48 ` linux-next: Tree for Nov 1 (ata/libata-sff.c) Randy Dunlap
2011-11-10 21:26 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC53F18.2080303@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@linux-foundation.org \
--cc=charrer@alacritech.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=liodot@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).