From: "Cousson, Benoit" <b-cousson@ti.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (mfd tree related)
Date: Wed, 21 Dec 2011 11:51:27 +0100 [thread overview]
Message-ID: <4EF1BA2F.9090304@ti.com> (raw)
In-Reply-To: <20111221173301.1111dc371e11d5c7025f03ea@canb.auug.org.au>
Hi Stephen,
On 12/21/2011 7:33 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/mfd/twl-core.c: In function 'twl_probe':
> drivers/mfd/twl-core.c:1212:22: error: 'TWL6030_IRQ_BASE' undeclared (first use in this function)
> drivers/mfd/twl-core.c:1212:22: note: each undeclared identifier is reported only once for each function it appears in
> drivers/mfd/twl-core.c:1213:39: error: 'TWL6030_BASE_NR_IRQS' undeclared (first use in this function)
> drivers/mfd/twl-core.c:1215:22: error: 'TWL4030_IRQ_BASE' undeclared (first use in this function)
> drivers/mfd/twl-core.c:1216:39: error: 'TWL4030_BASE_NR_IRQS' undeclared (first use in this function)
> drivers/mfd/twl-core.c:1218:3: error: implicit declaration of function 'irq_domain_add_simple' [-Werror=implicit-function-declaration]
>
> Caused by commit 4eea8b1d717d ("mfd: Add initial DT support for
> twl4030/twl6030"). A missing include? Or a CONFIG problem?
Both in fact...
There are some nasty dependencies with that TWL driver and the IRQ
defined in OMAP headers only. I was fooled by the name of these macros.
I naively thought this could be fixed later as written in the comment I
added. I appears this is not the case :-(.
> This build does not have CONFIG_IRQ_DOMAIN set.
Ooops, I was not aware of that domain CONFIG. That one is an easy fix.
Samuel,
Just let me know if you will have time for an updated version before Xmas.
I'll try to fix that by using irq_alloc_descs to avoid these hard-coded
macros. It might conflict with the still hard coded GPIO IRQs range, but
I'll see if it work for DT only at least.
Thanks,
Benoit
next prev parent reply other threads:[~2011-12-21 10:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 6:33 linux-next: build failure after merge of the final tree (mfd tree related) Stephen Rothwell
2011-12-21 10:51 ` Cousson, Benoit [this message]
2011-12-21 12:24 ` Samuel Ortiz
2011-12-22 17:30 ` Samuel Ortiz
-- strict thread matches above, loose matches on Subject: below --
2013-06-18 7:19 Stephen Rothwell
2013-06-19 8:24 ` Samuel Ortiz
2013-06-20 2:25 ` Chao Xie
2012-09-17 11:38 Stephen Rothwell
2012-09-17 13:28 ` Samuel Ortiz
2011-03-28 3:52 Stephen Rothwell
2011-03-21 8:12 함명주
2011-03-21 2:59 Stephen Rothwell
2010-12-20 8:21 Stephen Rothwell
2010-12-20 10:33 ` Samuel Ortiz
2010-12-20 10:52 ` Mark Brown
2010-12-20 12:18 ` Mark Brown
2010-09-14 3:43 Stephen Rothwell
2010-09-14 5:05 ` Arun MURTHY
2010-09-16 7:15 ` Arun MURTHY
2010-09-16 7:23 ` Stephen Rothwell
2010-09-16 8:51 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF1BA2F.9090304@ti.com \
--to=b-cousson@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).