* Re: [PATCH] ath6kl: force building as a module [not found] <20120104094134.28754.39652.stgit@x201> @ 2012-01-04 9:48 ` Kalle Valo [not found] ` <4F042078.5040902-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org> 0 siblings, 1 reply; 2+ messages in thread From: Kalle Valo @ 2012-01-04 9:48 UTC (permalink / raw) To: linville-2XuSBdqkA4R54TAoqtyWWQ Cc: ath6kl-devel-zC7DfRvBq/JWk0Htik3J/w, linux-wireless-u79uwXL29TY76Z2rM5mHXA, Stephen Rothwell, David Miller, linux-next-u79uwXL29TY76Z2rM5mHXA On 01/04/2012 11:41 AM, Kalle Valo wrote: > Stephen reported that ath6kl fails if both sdio and usb are built > into the kernel: > > ath6kl/cfg80211.c:27:1: error: expected ')' before 'KBUILD_MODNAME' > ath6kl/cfg80211.c:27:1: error: 'KBUILD_MODNAME' undeclared here (not in a function) > ath6kl/cfg80211.c:27:1: error: expected ',' or ';' before string constant > > As a temporary fix make ath6kl build only as a module. This will be reverted > once a separate ath6kl core module is implemented which will fix this > properly. > > Reported-by: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> > Signed-off-by: Kalle Valo <kvalo-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org> Sorry, forgot to CC people. The original patch is here: http://marc.info/?l=linux-wireless&m=132567025132302&w=2 John, can you please take this directly so that the build problem gets fixed quickly? I will also apply it to ath6kl.git but that should not create any merge problems. Kalle -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <4F042078.5040902-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org>]
* Re: [PATCH] ath6kl: force building as a module [not found] ` <4F042078.5040902-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org> @ 2012-01-04 18:28 ` David Miller 0 siblings, 0 replies; 2+ messages in thread From: David Miller @ 2012-01-04 18:28 UTC (permalink / raw) To: kvalo-A+ZNKFmMK5xy9aJCnZT0Uw Cc: linville-2XuSBdqkA4R54TAoqtyWWQ, ath6kl-devel-zC7DfRvBq/JWk0Htik3J/w, linux-wireless-u79uwXL29TY76Z2rM5mHXA, sfr-3FnU+UHB4dNDw9hX6IcOSA, linux-next-u79uwXL29TY76Z2rM5mHXA From: Kalle Valo <kvalo-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org> Date: Wed, 4 Jan 2012 11:48:40 +0200 > On 01/04/2012 11:41 AM, Kalle Valo wrote: >> Stephen reported that ath6kl fails if both sdio and usb are built >> into the kernel: >> >> ath6kl/cfg80211.c:27:1: error: expected ')' before 'KBUILD_MODNAME' >> ath6kl/cfg80211.c:27:1: error: 'KBUILD_MODNAME' undeclared here (not in a function) >> ath6kl/cfg80211.c:27:1: error: expected ',' or ';' before string constant >> >> As a temporary fix make ath6kl build only as a module. This will be reverted >> once a separate ath6kl core module is implemented which will fix this >> properly. >> >> Reported-by: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org> >> Signed-off-by: Kalle Valo <kvalo-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org> > > Sorry, forgot to CC people. The original patch is here: > > http://marc.info/?l=linux-wireless&m=132567025132302&w=2 > > John, can you please take this directly so that the build problem gets > fixed quickly? I will also apply it to ath6kl.git but that should not > create any merge problems. John can you very much NOT include this change, and if the ath6kl maintainers can't fix this properly then revert the changes that caused this regression in the first place? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-04 18:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20120104094134.28754.39652.stgit@x201>
2012-01-04 9:48 ` [PATCH] ath6kl: force building as a module Kalle Valo
[not found] ` <4F042078.5040902-A+ZNKFmMK5xy9aJCnZT0Uw@public.gmane.org>
2012-01-04 18:28 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).