[PATCH] thermal: add missing HAS_IOMEM dependency for SPEAr13x thermal sensor driver

[PATCH] thermal: add missing HAS_IOMEM dependency for SPEAr13x thermal sensor driver

[Heiko Carstens]

Fix this build error on s390:

drivers/thermal/spear_thermal.c: In function 'thermal_get_temp':
drivers/thermal/spear_thermal.c:49:2: error:
   implicit declaration of function 'readl' [-Werror=implicit-function-declaration]

Cc: Vincenzo Frascino <vincenzo.frascino@st.com>
Cc: Viresh Kumar <viresh.kumar@st.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
 drivers/thermal/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 2633fe0..06101a7 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -21,7 +21,7 @@ config THERMAL_HWMON
 
 config SPEAR_THERMAL
 	bool "SPEAr thermal sensor driver"
-	depends on THERMAL
+	depends on THERMAL && HAS_IOMEM
 	help
 	  Enable this to plug the SPEAr thermal sensor driver into the Linux
 	  thermal framework
-- 
1.7.9

Re: [PATCH] thermal: add missing HAS_IOMEM dependency for SPEAr13x thermal sensor driver

[Vincenzo Frascino]

Thanks Heiko,

Il 29/02/2012 13:40, Heiko Carstens ha scritto:
> Fix this build error on s390:
>
> drivers/thermal/spear_thermal.c: In function 'thermal_get_temp':
> drivers/thermal/spear_thermal.c:49:2: error:
>    implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
>
> Cc: Vincenzo Frascino <vincenzo.frascino@st.com>
> Cc: Viresh Kumar <viresh.kumar@st.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
>  drivers/thermal/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 2633fe0..06101a7 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -21,7 +21,7 @@ config THERMAL_HWMON
>  
>  config SPEAR_THERMAL
>  	bool "SPEAr thermal sensor driver"
> -	depends on THERMAL
> +	depends on THERMAL && HAS_IOMEM
>  	help
>  	  Enable this to plug the SPEAr thermal sensor driver into the Linux
>  	  thermal framework
Reviewed-by: Vincenzo Frascino <vincenzo.frascino@st.com>

Re: [PATCH] thermal: add missing HAS_IOMEM dependency for SPEAr13x thermal sensor driver

[Paul Gortmaker]

On Wed, Feb 29, 2012 at 9:17 AM, Vincenzo Frascino
<vincenzo.frascino@st.com> wrote:
> Thanks Heiko,
>
> Il 29/02/2012 13:40, Heiko Carstens ha scritto:
>> Fix this build error on s390:
>>
>> drivers/thermal/spear_thermal.c: In function 'thermal_get_temp':
>> drivers/thermal/spear_thermal.c:49:2: error:
>>    implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
>>
>> Cc: Vincenzo Frascino <vincenzo.frascino@st.com>
>> Cc: Viresh Kumar <viresh.kumar@st.com>
>> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
>> ---
>>  drivers/thermal/Kconfig |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
>> index 2633fe0..06101a7 100644
>> --- a/drivers/thermal/Kconfig
>> +++ b/drivers/thermal/Kconfig
>> @@ -21,7 +21,7 @@ config THERMAL_HWMON
>>
>>  config SPEAR_THERMAL
>>       bool "SPEAr thermal sensor driver"
>> -     depends on THERMAL
>> +     depends on THERMAL && HAS_IOMEM

No, we dont need this.  The better patch was already posted:

   https://lkml.org/lkml/2012/2/26/155

I've tested the above "depends on PLAT_SPEAR" patch and
confirmed it fixes the s390 build failures that just appeared in
linux-next.  This is the patch we need in the akpm queue.

Thanks,
Paul.
--

>>       help
>>         Enable this to plug the SPEAr thermal sensor driver into the Linux
>>         thermal framework
> Reviewed-by: Vincenzo Frascino <vincenzo.frascino@st.com>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html