From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: tomoya.rohm@gmail.com, Felipe Balbi <balbi@ti.com>
Cc: linux-next@vger.kernel.org
Subject: "usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt" breaks sparc
Date: Fri, 2 Mar 2012 17:01:16 -0500 [thread overview]
Message-ID: <4F51432C.8020204@windriver.com> (raw)
This commit:
---------------
commit 637b78eb31e0b167ed913f1750bb645dfeda38f0
Author: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Date: Fri Feb 3 16:14:18 2012 +0900
usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt
Problem:
pch_udc continues operation even if VBUS becomes Low.
pch_udc performs D+ pulling up before VBUS becomes High.
USB device should be controlled according to VBUS state.
Root cause:
The current pch_udc is not always monitoring VBUS.
Solution:
The change of VBUS is detected using an interrupt of GPIO.
If VBUS became Low, pch_udc handles 'disconnect'.
After VBUS became High, a pull improves D+, and pch_udc
handles 'connect'.
[ balbi@ti.com : make it actually compile ]
Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
---------------
breaks the sparc builds in next:
http://kisskb.ellerman.id.au/kisskb/buildresult/5771890/
http://kisskb.ellerman.id.au/kisskb/buildresult/5771905/
Thanks,
Paul.
next reply other threads:[~2012-03-02 22:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 22:01 Paul Gortmaker [this message]
2012-03-02 23:41 ` "usb: gadget: pch_udc: Detecting VBUS through GPIO with interrupt" breaks sparc Stephen Rothwell
2012-03-05 16:43 ` Greg KH
2012-03-06 0:07 ` Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F51432C.8020204@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=balbi@ti.com \
--cc=linux-next@vger.kernel.org \
--cc=tomoya.rohm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox