From: Randy Dunlap <rdunlap@xenotime.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
devel@driverdev.osuosl.org, Brian Swetland <swetland@google.com>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for Mar 15 (staging/android/ram_console.c)
Date: Thu, 15 Mar 2012 14:39:56 -0700 [thread overview]
Message-ID: <4F6261AC.7030903@xenotime.net> (raw)
In-Reply-To: <20120315210333.GA6647@kroah.com>
On 03/15/2012 02:03 PM, Greg Kroah-Hartman wrote:
> On Thu, Mar 15, 2012 at 08:58:02AM -0700, Randy Dunlap wrote:
>> On 03/15/2012 12:59 AM, Stephen Rothwell wrote:
>>
>>> Hi all,
>>>
>>> News: the build system (see below) has had its toolchains for most
>>> architectures updated to gcc 4.6.3. People might like to check the build
>>> results and consider if this change has caused any problems. There are
>>> also a number of architectures that are building today for the first
>>> time. Thanks to Tony Breeds for his efforts in providing toolchains.
>>>
>>> Changes since 20120314:
>>
>>
>>
>> on x86_64 when CONFIG_PRINTK is not enabled:
>>
>>
>> drivers/staging/android/ram_console.c:99:6: error: 'dmesg_restrict' undeclared (first use in this function)
>
> This patch should solve this, right?
>
>
> diff --git a/drivers/staging/android/ram_console.c b/drivers/staging/android/ram_console.c
> index 2918bc1..ce140ff 100644
> --- a/drivers/staging/android/ram_console.c
> +++ b/drivers/staging/android/ram_console.c
> @@ -85,6 +85,10 @@ static int __init ram_console_module_init(void)
> return platform_driver_probe(&ram_console_driver, ram_console_probe);
> }
>
> +#ifndef CONFIG_PRINTK
> +#define dmesg_restrict 0
> +#endif
> +
> static ssize_t ram_console_read_old(struct file *file, char __user *buf,
> size_t len, loff_t *offset)
> {
Yes, thanks.
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
--
~Randy
prev parent reply other threads:[~2012-03-15 21:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 7:59 linux-next: Tree for Mar 15 Stephen Rothwell
2012-03-15 8:02 ` Geert Uytterhoeven
2012-03-15 8:17 ` Stephen Rothwell
2012-03-15 15:48 ` linux-next: Tree for Mar 15 (crypto) Randy Dunlap
2012-03-15 20:05 ` Jussi Kivilinna
2012-03-15 20:11 ` [PATCH 1/2] crypto: camellia-x86_64 - module init/exit functions should be static Jussi Kivilinna
2012-03-15 22:49 ` Randy Dunlap
2012-03-22 0:40 ` Randy Dunlap
2012-03-22 0:46 ` Herbert Xu
2012-03-22 21:18 ` H. Peter Anvin
2012-03-23 0:42 ` Herbert Xu
2012-03-15 20:11 ` [PATCH 2/2] crypto: twofish-x86_64-3way " Jussi Kivilinna
2012-03-15 22:49 ` Randy Dunlap
2012-03-15 15:58 ` linux-next: Tree for Mar 15 (staging/android/ram_console.c) Randy Dunlap
2012-03-15 21:03 ` Greg Kroah-Hartman
2012-03-15 21:39 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6261AC.7030903@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).