From: Michal Marek <mmarek@suse.cz>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] kbuild: all{no,yes,mod,def,rand}config only read files when instructed to.
Date: Mon, 07 May 2012 21:04:11 +0200 [thread overview]
Message-ID: <4FA81CAB.1040405@suse.cz> (raw)
In-Reply-To: <m11umwjheu.fsf@fess.ebiederm.org>
Dne 7.5.2012 14:37, Eric W. Biederman napsal(a):
>
> Prevent subtle surprises to both people working on the kconfig code
> and people using make allnoconfig allyesconfig allmoconfig and
> randconfig by only attempting to read a config file if
> KCONFIG_ALLCONFIG is set.
>
> Common sense suggests attempting to read the extra config files does
> not make sense unless requested. The documentation says the code
> won't attempt to read the extra config files unless requested.
> Current usage does not appear to include people depending on the code
> reading the config files without the variable being set
It's true that this bug/feature has been there since the introduction of
KCONFIG_ALLCONFIG, but I doubt anyone relies on it.
> So do the
> simple thing and stop reading config files when passed
> all{no,yes,mod,def,rand}config unless KCONFIG_ALLCONFIG environment
> variable is set.
Yes! I applied to kbuild.git#kconfig, with Reported-by: Stephen. Thanks
to both of you.
Michal
prev parent reply other threads:[~2012-05-07 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 7:03 linux-next: build failure after merge of the final tree (kbuild tree related) Stephen Rothwell
2012-05-07 12:37 ` [PATCH] kbuild: all{no,yes,mod,def,rand}config only read files when instructed to Eric W. Biederman
2012-05-07 19:04 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA81CAB.1040405@suse.cz \
--to=mmarek@suse.cz \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).