From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Marek Subject: Re: [PATCH] kbuild: all{no,yes,mod,def,rand}config only read files when instructed to. Date: Mon, 07 May 2012 21:04:11 +0200 Message-ID: <4FA81CAB.1040405@suse.cz> References: <20120507170319.03aa2fe980a39669c393a956@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from cantor2.suse.de ([195.135.220.15]:44654 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757499Ab2EGS7I (ORCPT ); Mon, 7 May 2012 14:59:08 -0400 In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: "Eric W. Biederman" Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Rothwell Dne 7.5.2012 14:37, Eric W. Biederman napsal(a): > > Prevent subtle surprises to both people working on the kconfig code > and people using make allnoconfig allyesconfig allmoconfig and > randconfig by only attempting to read a config file if > KCONFIG_ALLCONFIG is set. > > Common sense suggests attempting to read the extra config files does > not make sense unless requested. The documentation says the code > won't attempt to read the extra config files unless requested. > Current usage does not appear to include people depending on the code > reading the config files without the variable being set It's true that this bug/feature has been there since the introduction of KCONFIG_ALLCONFIG, but I doubt anyone relies on it. > So do the > simple thing and stop reading config files when passed > all{no,yes,mod,def,rand}config unless KCONFIG_ALLCONFIG environment > variable is set. Yes! I applied to kbuild.git#kconfig, with Reported-by: Stephen. Thanks to both of you. Michal