linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Chris Ball <cjb@laptop.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	linus.walleij@stericsson.com, arnd@arndb.de,
	Linus Walleij <linus.walleij@linaro.org>,
	grant.likely@secretlab.ca, linux-arm-kernel@lists.infradead.org,
	linux-next@vger.kernel.org
Subject: Re: [PATCH 6.2/7] MMC: mmci: Enable Device Tree support for ux500
Date: Tue, 08 May 2012 13:59:38 +0100	[thread overview]
Message-ID: <4FA918BA.3080303@linaro.org> (raw)
In-Reply-To: <878vh2rhlh.fsf@laptop.org>

Here you go Chris.

From: Lee Jones <lee.jones@linaro.org>
Date: Tue, 8 May 2012 13:40:02 +0100
Subject: [PATCH] MMC: mmci: Fix compiler error when CONFIG_OF is not set

error: implicit declaration of function 'mmci_dt_populate_generic_pdata'

This is due to the '#if CONFIG_OF' guards placed around
mmci_dt_populate_generic_pdata(), but not around the call to it. We
repair this by inserting a stub which elegantly returns when CONFIG_OF
is not set.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mmc/host/mmci.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
index 2303a16..efc822d 100644
--- a/drivers/mmc/host/mmci.c
+++ b/drivers/mmc/host/mmci.c
@@ -1241,6 +1241,12 @@ static void mmci_dt_populate_generic_pdata(struct device_node *np,
 		pr_warn("%s: Unsupported bus width\n", np->full_name);
 	}
 }
+#else
+static void mmci_dt_populate_generic_pdata(struct device_node *np,
+					struct mmci_platform_data *pdata)
+{
+	return;
+}
 #endif
 
 static int __devinit mmci_probe(struct amba_device *dev,
-- 
1.7.9.5

  reply	other threads:[~2012-05-08 12:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1334325909-5779-1-git-send-email-lee.jones@linaro.org>
     [not found] ` <1334325909-5779-7-git-send-email-lee.jones@linaro.org>
     [not found]   ` <CACRpkdYyP=V=aXtDuo_W4oDxH0UkQKq1x1HKG_z=zWHoWng6JQ@mail.gmail.com>
     [not found]     ` <4F8BE5B0.4000900@linaro.org>
     [not found]       ` <20120425185747.GC24211@n2100.arm.linux.org.uk>
     [not found]         ` <4FA29E46.6040204@linaro.org>
     [not found]           ` <20120503151253.GE897@n2100.arm.linux.org.uk>
     [not found]             ` <4FA2A4A8.9010208@linaro.org>
     [not found]               ` <20120503163008.GF897@n2100.arm.linux.org.uk>
     [not found]                 ` <4FA2B4A3.2040402@linaro.org>
     [not found]                   ` <20120503164501.GG897@n2100.arm.linux.org.uk>
     [not found]                     ` <8762cdur7o.fsf@laptop.org>
     [not found]                       ` <4FA3D720.7010004@linaro.org>
     [not found]                         ` <87mx5ot6vp.fsf@laptop.org>
     [not found]                           ` <4FA3DC27.6030204@linaro.org>
2012-05-07 22:00                             ` [PATCH 6.2/7] MMC: mmci: Enable Device Tree support for ux500 Paul Gortmaker
2012-05-08 11:19                               ` Lee Jones
2012-05-08 12:18                                 ` Chris Ball
2012-05-08 12:59                                   ` Lee Jones [this message]
2012-05-08 14:38                                     ` Chris Ball
2012-05-08 23:58                                     ` Paul Gortmaker
2012-05-09  0:29                                       ` Chris Ball
2012-05-09  0:52                                         ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FA918BA.3080303@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=arnd@arndb.de \
    --cc=cjb@laptop.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linus.walleij@linaro.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).