From: Randy Dunlap <rdunlap@xenotime.net>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for Jun 20 (hweight return type)
Date: Wed, 20 Jun 2012 18:10:09 -0700 [thread overview]
Message-ID: <4FE27471.8050505@xenotime.net> (raw)
In-Reply-To: <20120620173536.b856bbd97497cf02ddf8d6d2@canb.auug.org.au>
On 06/20/2012 12:35 AM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20120619:
Someone changes the return type of __const_hweight8() to
(unsigned long). That causes printk format warnings when
hweight8/16() etc. is passed a constant:
drivers/input/joystick/analog.c:412:4: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
drivers/input/joystick/analog.c:412:4: warning: format '%d' expects type 'int', but argument 5 has type 'long unsigned int'
drivers/input/joystick/analog.c:416:5: warning: format '%d' expects type 'int', but argument 5 has type 'long unsigned int'
Note that in
#define hweight8(w) (__builtin_constant_p(w) ? __const_hweight8(w) : __arch_hweight8(w))
__arch_hweight*() still returns unsigned int while __const_hweight*()
returns unsigned long. This can't be good, can it?
--
~Randy
next prev parent reply other threads:[~2012-06-21 1:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 7:35 linux-next: Tree for Jun 20 Stephen Rothwell
2012-06-21 1:10 ` Randy Dunlap [this message]
2012-06-21 1:45 ` linux-next: Tree for Jun 20 (hweight return type) Stephen Rothwell
2012-06-21 3:32 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE27471.8050505@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox