linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next-20100201 - OMAP2+ defconfig broken with CONFIG_DEBUG_LL
@ 2011-02-01  5:39 Gadiyar, Anand
  2011-02-01  9:22 ` Russell King - ARM Linux
  2011-02-01  9:23 ` linux-next-20100201 - OMAP2+ defconfig broken with CONFIG_DEBUG_LL Anand Gadiyar
  0 siblings, 2 replies; 6+ messages in thread
From: Gadiyar, Anand @ 2011-02-01  5:39 UTC (permalink / raw)
  To: linux-arm-kernel, linux-next

Hi all,

I tried to build linux-next as of 20100201 with omap2plus_defconfig. In addition
I turned on CONFIG_DEBUG_LL and hit the following error.

  AS      arch/arm/kernel/debug.o
arch/arm/kernel/debug.S: Assembler messages:
arch/arm/kernel/debug.S:174: Error: garbage following instruction --
`ldreq r1,=
__virt_to_phys(omap_uart_phys)'
arch/arm/kernel/debug.S:174: Error: garbage following instruction --
`ldrne r1,=
__phys_to_virt((0x80000000+0x3ffc))'
arch/arm/kernel/debug.S:174: Error: garbage following instruction --
`ldreq r2,=
__virt_to_phys(omap_uart_phys)'
arch/arm/kernel/debug.S:174: Error: garbage following instruction --
`ldreq r2,=
__virt_to_phys(omap_uart_phys)'
arch/arm/kernel/debug.S:178: Error: garbage following instruction --
`ldreq r2,=
__virt_to_phys(omap_uart_lsr)'
arch/arm/kernel/debug.S:190: Error: garbage following instruction --
`ldreq r1,=
__virt_to_phys(omap_uart_phys)'
arch/arm/kernel/debug.S:190: Error: garbage following instruction --
`ldrne r1,=
__phys_to_virt((0x80000000+0x3ffc))'
arch/arm/kernel/debug.S:190: Error: garbage following instruction --
`ldreq r2,=
__virt_to_phys(omap_uart_phys)'
arch/arm/kernel/debug.S:190: Error: garbage following instruction --
`ldreq r2,=
__virt_to_phys(omap_uart_phys)'
make[1]: *** [arch/arm/kernel/debug.o] Error 1
make: *** [arch/arm/kernel] Error 2

Will try and bisect this down later. Just reporting for now.

- Anand

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next-20100201 - OMAP2+ defconfig broken with CONFIG_DEBUG_LL
  2011-02-01  5:39 linux-next-20100201 - OMAP2+ defconfig broken with CONFIG_DEBUG_LL Gadiyar, Anand
@ 2011-02-01  9:22 ` Russell King - ARM Linux
  2011-02-01  9:25   ` linux-next-20100201 - OMAP2+ defconfig broken withCONFIG_DEBUG_LL Anand Gadiyar
  2011-02-01  9:23 ` linux-next-20100201 - OMAP2+ defconfig broken with CONFIG_DEBUG_LL Anand Gadiyar
  1 sibling, 1 reply; 6+ messages in thread
From: Russell King - ARM Linux @ 2011-02-01  9:22 UTC (permalink / raw)
  To: Gadiyar, Anand; +Cc: linux-arm-kernel, linux-next

On Tue, Feb 01, 2011 at 11:09:52AM +0530, Gadiyar, Anand wrote:
> Hi all,
> 
> I tried to build linux-next as of 20100201 with omap2plus_defconfig. In addition
> I turned on CONFIG_DEBUG_LL and hit the following error.

No need to bisect.  Tony knows about it.  It's the OMAP debug code using
what was a macro in assembly, which becomes a C function with the dynamic
P2V patches.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: linux-next-20100201 - OMAP2+ defconfig broken with CONFIG_DEBUG_LL
  2011-02-01  5:39 linux-next-20100201 - OMAP2+ defconfig broken with CONFIG_DEBUG_LL Gadiyar, Anand
  2011-02-01  9:22 ` Russell King - ARM Linux
@ 2011-02-01  9:23 ` Anand Gadiyar
  2011-02-01  9:26   ` Santosh Shilimkar
  1 sibling, 1 reply; 6+ messages in thread
From: Anand Gadiyar @ 2011-02-01  9:23 UTC (permalink / raw)
  To: linux-arm-kernel, linux-next, Russell King - ARM Linux

Gadiyar, Anand wrote:
> Hi all,
>
> I tried to build linux-next as of 20100201 with
> omap2plus_defconfig. In addition
> I turned on CONFIG_DEBUG_LL and hit the following error.
>
>   AS      arch/arm/kernel/debug.o
> arch/arm/kernel/debug.S: Assembler messages:
> arch/arm/kernel/debug.S:174: Error: garbage following instruction --
> `ldreq r1,=
> __virt_to_phys(omap_uart_phys)'
> arch/arm/kernel/debug.S:174: Error: garbage following instruction --
> `ldrne r1,=
> __phys_to_virt((0x80000000+0x3ffc))'
> arch/arm/kernel/debug.S:174: Error: garbage following instruction --
> `ldreq r2,=
> __virt_to_phys(omap_uart_phys)'
> arch/arm/kernel/debug.S:174: Error: garbage following instruction --
> `ldreq r2,=
> __virt_to_phys(omap_uart_phys)'
> arch/arm/kernel/debug.S:178: Error: garbage following instruction --
> `ldreq r2,=
> __virt_to_phys(omap_uart_lsr)'
> arch/arm/kernel/debug.S:190: Error: garbage following instruction --
> `ldreq r1,=
> __virt_to_phys(omap_uart_phys)'
> arch/arm/kernel/debug.S:190: Error: garbage following instruction --
> `ldrne r1,=
> __phys_to_virt((0x80000000+0x3ffc))'
> arch/arm/kernel/debug.S:190: Error: garbage following instruction --
> `ldreq r2,=
> __virt_to_phys(omap_uart_phys)'
> arch/arm/kernel/debug.S:190: Error: garbage following instruction --
> `ldreq r2,=
> __virt_to_phys(omap_uart_phys)'
> make[1]: *** [arch/arm/kernel/debug.o] Error 1
> make: *** [arch/arm/kernel] Error 2
>
> Will try and bisect this down later. Just reporting for now.
>

Hi Russell,

This appears to be introduced after this commit from you:

8397c0703b5aa99fdb7c4e5177c4e2fc3b97c835 is the first bad commit
commit 8397c0703b5aa99fdb7c4e5177c4e2fc3b97c835
Author: Russell King <rmk+kernel@arm.linux.org.uk>
Date:   Tue Jan 4 19:09:43 2011 +0000

    ARM: P2V: introduce phys_to_virt/virt_to_phys runtime patching

    This idea came from Nicolas, Eric Miao produced an initial version,
    which was then rewritten into this.

The build failure seems to be omap-specific; I don't see this when
I build a mx51_defconfig for instance, but I do get a similar error
when building for omap1_defconfig.

I'll try and dig deeper.

Thanks in advance for any pointers.

- Anand

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: linux-next-20100201 - OMAP2+ defconfig broken withCONFIG_DEBUG_LL
  2011-02-01  9:22 ` Russell King - ARM Linux
@ 2011-02-01  9:25   ` Anand Gadiyar
  0 siblings, 0 replies; 6+ messages in thread
From: Anand Gadiyar @ 2011-02-01  9:25 UTC (permalink / raw)
  To: Russell King - ARM Linux; +Cc: linux-next, linux-arm-kernel

Russell King - ARM Linux wrote:
> On Tue, Feb 01, 2011 at 11:09:52AM +0530, Gadiyar, Anand wrote:
> > Hi all,
> >
> > I tried to build linux-next as of 20100201 with omap2plus_defconfig.
In addition
> > I turned on CONFIG_DEBUG_LL and hit the following error.
>
> No need to bisect.  Tony knows about it.  It's the OMAP debug code using
> what was a macro in assembly, which becomes a C function with the
dynamic
> P2V patches.
>


Okay, thanks!

- Anand

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: linux-next-20100201 - OMAP2+ defconfig broken with CONFIG_DEBUG_LL
  2011-02-01  9:23 ` linux-next-20100201 - OMAP2+ defconfig broken with CONFIG_DEBUG_LL Anand Gadiyar
@ 2011-02-01  9:26   ` Santosh Shilimkar
  2011-02-04 19:59     ` Tony Lindgren
  0 siblings, 1 reply; 6+ messages in thread
From: Santosh Shilimkar @ 2011-02-01  9:26 UTC (permalink / raw)
  To: Anand Gadiyar, linux-arm-kernel, linux-next,
	Russell King - ARM Linux

> -----Original Message-----
> From: linux-arm-kernel-bounces@lists.infradead.org [mailto:linux-
> arm-kernel-bounces@lists.infradead.org] On Behalf Of Anand Gadiyar
> Sent: Tuesday, February 01, 2011 2:54 PM
> To: linux-arm-kernel@lists.infradead.org; linux-
> next@vger.kernel.org; Russell King - ARM Linux
> Subject: RE: linux-next-20100201 - OMAP2+ defconfig broken with
> CONFIG_DEBUG_LL
>
> Gadiyar, Anand wrote:
> > Hi all,
> >
> > I tried to build linux-next as of 20100201 with
> > omap2plus_defconfig. In addition
> > I turned on CONFIG_DEBUG_LL and hit the following error.
> >
> >   AS      arch/arm/kernel/debug.o
> > arch/arm/kernel/debug.S: Assembler messages:
> > arch/arm/kernel/debug.S:174: Error: garbage following instruction
> --
> > `ldreq r1,=
> > __virt_to_phys(omap_uart_phys)'
> > arch/arm/kernel/debug.S:174: Error: garbage following instruction
> --
> > `ldrne r1,=
> > __phys_to_virt((0x80000000+0x3ffc))'
> > arch/arm/kernel/debug.S:174: Error: garbage following instruction
> --
> > `ldreq r2,=
> > __virt_to_phys(omap_uart_phys)'
> > arch/arm/kernel/debug.S:174: Error: garbage following instruction
> --
> > `ldreq r2,=
> > __virt_to_phys(omap_uart_phys)'
> > arch/arm/kernel/debug.S:178: Error: garbage following instruction
> --
> > `ldreq r2,=
> > __virt_to_phys(omap_uart_lsr)'
> > arch/arm/kernel/debug.S:190: Error: garbage following instruction
> --
> > `ldreq r1,=
> > __virt_to_phys(omap_uart_phys)'
> > arch/arm/kernel/debug.S:190: Error: garbage following instruction
> --
> > `ldrne r1,=
> > __phys_to_virt((0x80000000+0x3ffc))'
> > arch/arm/kernel/debug.S:190: Error: garbage following instruction
> --
> > `ldreq r2,=
> > __virt_to_phys(omap_uart_phys)'
> > arch/arm/kernel/debug.S:190: Error: garbage following instruction
> --
> > `ldreq r2,=
> > __virt_to_phys(omap_uart_phys)'
> > make[1]: *** [arch/arm/kernel/debug.o] Error 1
> > make: *** [arch/arm/kernel] Error 2
> >
> > Will try and bisect this down later. Just reporting for now.
> >
>
> Hi Russell,
>
> This appears to be introduced after this commit from you:
>
> 8397c0703b5aa99fdb7c4e5177c4e2fc3b97c835 is the first bad commit
> commit 8397c0703b5aa99fdb7c4e5177c4e2fc3b97c835
> Author: Russell King <rmk+kernel@arm.linux.org.uk>
> Date:   Tue Jan 4 19:09:43 2011 +0000
>
>     ARM: P2V: introduce phys_to_virt/virt_to_phys runtime patching
>
>     This idea came from Nicolas, Eric Miao produced an initial
> version,
>     which was then rewritten into this.
>
> The build failure seems to be omap-specific; I don't see this when
> I build a mx51_defconfig for instance, but I do get a similar error
> when building for omap1_defconfig.
>
> I'll try and dig deeper.
>
This is known and Russell has already pointed this
out even before patch for dynamic p2v were merged.

OMAP LL debug code needs to be fixed.

Regards,
Santosh

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next-20100201 - OMAP2+ defconfig broken with CONFIG_DEBUG_LL
  2011-02-01  9:26   ` Santosh Shilimkar
@ 2011-02-04 19:59     ` Tony Lindgren
  0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2011-02-04 19:59 UTC (permalink / raw)
  To: Santosh Shilimkar
  Cc: Anand Gadiyar, linux-arm-kernel, linux-next,
	Russell King - ARM Linux

* Santosh Shilimkar <santosh.shilimkar@ti.com> [110201 01:25]:
> > -----Original Message-----
> > From: linux-arm-kernel-bounces@lists.infradead.org [mailto:linux-
> > arm-kernel-bounces@lists.infradead.org] On Behalf Of Anand Gadiyar
> > Sent: Tuesday, February 01, 2011 2:54 PM
> > To: linux-arm-kernel@lists.infradead.org; linux-
> > next@vger.kernel.org; Russell King - ARM Linux
> > Subject: RE: linux-next-20100201 - OMAP2+ defconfig broken with
> > CONFIG_DEBUG_LL
> >
> > Gadiyar, Anand wrote:
> > > Hi all,
> > >
> > > I tried to build linux-next as of 20100201 with
> > > omap2plus_defconfig. In addition
> > > I turned on CONFIG_DEBUG_LL and hit the following error.

Posted a fix for that yesterday. Will upload it into Russell's
patch system for the p2v branch.

Tony

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-02-04 20:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-01  5:39 linux-next-20100201 - OMAP2+ defconfig broken with CONFIG_DEBUG_LL Gadiyar, Anand
2011-02-01  9:22 ` Russell King - ARM Linux
2011-02-01  9:25   ` linux-next-20100201 - OMAP2+ defconfig broken withCONFIG_DEBUG_LL Anand Gadiyar
2011-02-01  9:23 ` linux-next-20100201 - OMAP2+ defconfig broken with CONFIG_DEBUG_LL Anand Gadiyar
2011-02-01  9:26   ` Santosh Shilimkar
2011-02-04 19:59     ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).