From: Jens Axboe <axboe@kernel.dk>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
Pavel Begunkov <asml.silence@gmail.com>
Subject: Re: Fixes tags need work in the block tree
Date: Thu, 2 Apr 2026 06:59:03 -0600 [thread overview]
Message-ID: <4d20cb99-a529-4cb0-9c80-441944e1aa60@kernel.dk> (raw)
In-Reply-To: <ac5UWqRPp54d1bM0@sirena.org.uk>
On 4/2/26 5:34 AM, Mark Brown wrote:
> In commit
>
> 7a9ffcf2cbf88 ("io_uring/zcrx: use dma_len for chunk size calculation")
>
> Fixes tag
>
> Fixes: 8c0cab0b7bf76 ("always dma map in advance")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
Fixed this and the other one. Pavel, JFYI. What I usually say is
add:
[pretty]
fixes = Fixes: %h (\"%s\")
[alias]
fixes = log -1 --format=fixes
to your ~/.gitconfig so you can just run:
$ git fixes 8c0cab0b7bf768594e8efc73f7b8f3d5abeb74f1
Fixes: 8c0cab0b7bf7 ("io_uring/zcrx: always dma map in advance")
and it does the right thing for you. Nobody remembers that full git log
line, and then people try and do it manually, and invariably mess up the
formatting. git fixes <sha> is the way.
--
Jens Axboe
next prev parent reply other threads:[~2026-04-02 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 11:34 Fixes tags need work in the block tree Mark Brown
2026-04-02 12:59 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-02 11:34 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d20cb99-a529-4cb0-9c80-441944e1aa60@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox