From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH -next] wireless: brcmfmac: fix printk format warning Date: Thu, 01 Nov 2012 14:14:51 -0700 Message-ID: <5092E64B.3030402@infradead.org> References: <20121101163622.129b59967d2ee76e6946874a@canb.auug.org.au> <5092B4BE.4080803@infradead.org> <5092B900.2090801@broadcom.com> ( sfid-20121101_190234_358746_9918835B) <1351798279.17469.0.camel@jlt4.sipsolutions.net> <5092E0B7.9040608@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from casper.infradead.org ([85.118.1.10]:41747 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047Ab2KAVPC (ORCPT ); Thu, 1 Nov 2012 17:15:02 -0400 In-Reply-To: <5092E0B7.9040608@broadcom.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Arend van Spriel Cc: Johannes Berg , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211-dev-list@broadcom.com, linux-wireless@vger.kernel.org On 11/01/2012 01:51 PM, Arend van Spriel wrote: > On 11/01/2012 08:31 PM, Johannes Berg wrote: >> On Thu, 2012-11-01 at 19:01 +0100, Arend van Spriel wrote: >>> On 11/01/2012 06:43 PM, Randy Dunlap wrote: >>>> From: Randy Dunlap >>>> >>>> Fix printk format warning for ssid_len, which is a size_t: >>>> >>>> drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3941:2: warning: format '%d' expects type 'int', but argument 4 has type 'size_t' >>>> >>>> Signed-off-by: Randy Dunlap >>>> Cc: brcm80211-dev-list@broadcom.com >>> >>> >>> We actually have a patch ready for that with credit to people who >>> reported it. We can add you to that list ;-) >> >> Which you've been sitting on for WAY too long already :) >> >> johannes >> >> > > True. I was actually going to make Hante fix it, but failed my > management skills miserably. Fixed it myself in the end. There are quite > a number of patches queued up. Another flush() not working :-) Please get them into your linux-next tree so that we don't waste time fixing things that are already fixed. thanks, -- ~Randy