Re: linux-next: Tree for Jan 7 (rcutorture)

[Randy Dunlap <rdunlap@infradead.org>]

On 01/07/13 19:53, Paul E. McKenney wrote:
> On Mon, Jan 07, 2013 at 07:36:19PM -0500, Steven Rostedt wrote:
>> On Mon, 2013-01-07 at 18:12 -0500, Steven Rostedt wrote:
>>> On Tue, 2013-01-08 at 09:59 +1100, Stephen Rothwell wrote:
>>>> Hi Paul,
>>>>
>>>> On Mon, 7 Jan 2013 14:16:27 -0800 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
>>>>>
>>>>> On Mon, Jan 07, 2013 at 11:42:36AM -0800, Randy Dunlap wrote:
>>>>>>
>>>>>> on i386 or x86_64:
>>>>>>
>>>>>> ERROR: "trace_clock_local" [kernel/rcutorture.ko] undefined!
>>>>>
>>>>> Hello, Randy,
>>>>>
>>>>> Did your build include the following, also pushed to -next in that same
>>>>> batch from -rcu?  Including Steven Rostedt on CC for his take.
>>>>
>>>> That commit was certainly in next-20130107.
>>>
>>> Could be bad config dependencies.
>>
>> Paul,
>>
>> You need to also select TRACE_CLOCK if you are going to use it.
> 
> Thank you, Steve!
> 
> Randy, does the following patch help?

Yes, that's good.

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.


> 							Thanx, Paul
> 
> ------------------------------------------------------------------------
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index ce75d3b..b0fe7bd 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1010,6 +1010,7 @@ config RCU_CPU_STALL_INFO
>  config RCU_TRACE
>  	bool "Enable tracing for RCU"
>  	depends on DEBUG_KERNEL
> +	select TRACE_CLOCK
>  	help
>  	  This option provides tracing in RCU which presents stats
>  	  in debugfs for debugging RCU implementation.
> 
> --



-- 
~Randy