From: Stephen Warren <swarren@wwwdotorg.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Rob Clark <robdclark@gmail.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
Mark Zhang <markz@nvidia.com>
Subject: Broken build due to 6aed8ec "drm: review locking for drm_fb_helper_restore_fbdev_mode"
Date: Tue, 19 Feb 2013 10:48:12 -0700 [thread overview]
Message-ID: <5123BADC.2050807@wwwdotorg.org> (raw)
Daniel,
Commit 6aed8ec "drm: review locking for
drm_fb_helper_restore_fbdev_mode" (now in next-20130218 and later)
causes build failures for tegra_defconfig. The issue is this part of the
patch:
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index 3742bc9..1b6ba2d 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -389,8 +389,10 @@ EXPORT_SYMBOL_GPL(drm_fbdev_cma_fini);
> */
> void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma)
> {
> + drm_modeset_lock_all(dev);
> if (fbdev_cma)
> drm_fb_helper_restore_fbdev_mode(&fbdev_cma->fb_helper);
> + drm_modeset_unlock_all(dev);
> }
> EXPORT_SYMBOL_GPL(drm_fbdev_cma_restore_mode);
There, there is no "dev" variable, so compile fails.
If I revert this one patch, the build succeeds, although I didn't check
whether DRM still works after that (e.g. due to any dependencies from
the rest of the series).
next reply other threads:[~2013-02-19 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 17:48 Stephen Warren [this message]
2013-02-19 18:56 ` Broken build due to 6aed8ec "drm: review locking for drm_fb_helper_restore_fbdev_mode" Daniel Vetter
[not found] ` <CAKMK7uG=x4ESF_uVUwvK+0kzvsXEgZBtM9Z6_Qrm6keSasoCbA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-02-19 19:29 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5123BADC.2050807@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=markz@nvidia.com \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).