From: Stephen Boyd <sboyd@codeaurora.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: mmotm 2013-03-01-15-50 uploaded (strict user copy)
Date: Fri, 01 Mar 2013 19:42:55 -0800 [thread overview]
Message-ID: <5131753F.3070302@codeaurora.org> (raw)
In-Reply-To: <51316B64.90102@infradead.org>
On 03/01/13 19:00, Randy Dunlap wrote:
> On 03/01/13 15:51, akpm@linux-foundation.org wrote:
>> The mm-of-the-moment snapshot 2013-03-01-15-50 has been uploaded to
>>
>> http://www.ozlabs.org/~akpm/mmotm/
>>
>
> on i386:
>
> ERROR: "copy_from_user_overflow" [fs/binfmt_misc.ko] undefined!
>
> which I don't understand.
> lib/usercopy.o is built and building binfmt_misc.c says:
>
> CC [M] fs/binfmt_misc.o
> In file included from arch/x86/include/asm/uaccess.h:537:0,
> from include/linux/uaccess.h:5,
> from include/linux/highmem.h:8,
> from include/linux/pagemap.h:10,
> from fs/binfmt_misc.c:27:
> arch/x86/include/asm/uaccess_32.h: In function 'parse_command.part.1':
> arch/x86/include/asm/uaccess_32.h:211:26: warning: call to 'copy_from_user_overflow' declared with attribute warning: copy_from_user() buffer size is not provably correct [enabled by default]
Hm.. That's because it's part of lib and not obj, right?
diff --git a/lib/Makefile b/lib/Makefile
index 59fabd0..4c55104 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -15,7 +15,7 @@ lib-y := ctype.o string.o vsprintf.o cmdline.o \
is_single_threaded.o plist.o decompress.o kobject_uevent.o \
earlycpio.o percpu-refcount.o
-lib-$(CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS) += usercopy.o
+obj-$(CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS) += usercopy.o
lib-$(CONFIG_MMU) += ioremap.o
lib-$(CONFIG_SMP) += cpumask.o
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-03-02 3:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 23:51 mmotm 2013-03-01-15-50 uploaded akpm
2013-03-02 3:00 ` mmotm 2013-03-01-15-50 uploaded (strict user copy) Randy Dunlap
2013-03-02 3:42 ` Stephen Boyd [this message]
2013-03-02 4:16 ` Stephen Boyd
2013-03-02 5:22 ` Randy Dunlap
2013-03-14 17:48 ` Stephen Boyd
2013-03-14 21:16 ` Randy Dunlap
2013-03-02 3:05 ` mmotm 2013-03-01-15-50 uploaded (early_printk) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5131753F.3070302@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).