From: Ian Lartey <ian@slimlogic.co.uk>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Grant Likely <grant.likely@secretlab.ca>,
linux-next <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Graeme Gregory <gg@slimlogic.co.uk>
Subject: Re: linux-next: build failure after merge of the final tree (gpio tree relatred)
Date: Wed, 20 Mar 2013 15:41:31 +0000 [thread overview]
Message-ID: <5149D8AB.7020101@slimlogic.co.uk> (raw)
In-Reply-To: <20130321022524.37baf9fedb1848cdbdfc0eef@canb.auug.org.au>
On 20/03/13 15:25, Stephen Rothwell wrote:
> Hi Grant,
>
> On Wed, 6 Mar 2013 09:10:42 +0800 Grant Likely <grant.likely@secretlab.ca> wrote:
>>
>> On Wed, Mar 6, 2013 at 8:44 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>
>>> After merging the final tree, today's linux-next build (powerpc
>>> allyesconfig) failed like this:
>>>
>>> drivers/gpio/gpio-palmas.c: In function 'palmas_gpio_probe':
>>> drivers/gpio/gpio-palmas.c:173:2: error: implicit declaration of function 'is_palmas_charger' [-Werror=implicit-function-declaration]
>>> drivers/gpio/gpio-palmas.c:173:30: error: 'struct palmas' has no member named 'product_id'
>>>
>>> Caused by commit 82d4d6637fdf ("gpio/palmas: add in GPIO support for
>>> palmas charger"). I wonder if this was ever build tested. :-(
>>
>> Probably not. Looks like this driver doesn't get enabled without the
>> associated option in MFD. I didn't go searching for it, so my build
>> tests didn't catch it. I'll drop the patch from my tree. Sorry for the
>> pain.
>
> I am still having to revert this commit .... :-(
>
Sorry Stephen - There's a new patch series, that should resolve this,
undergoing review at the moment so that patch should be reverted...
for now.
Regards,
Ian
next prev parent reply other threads:[~2013-03-20 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 0:44 linux-next: build failure after merge of the final tree (gpio tree relatred) Stephen Rothwell
2013-03-06 1:10 ` Grant Likely
2013-03-20 15:25 ` Stephen Rothwell
2013-03-20 15:41 ` Ian Lartey [this message]
2013-03-20 15:57 ` Grant Likely
2013-03-20 22:05 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5149D8AB.7020101@slimlogic.co.uk \
--to=ian@slimlogic.co.uk \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).