From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Alexandre Courbot <gnurou@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Shaveta Leekha <shaveta@freescale.com>,
Christian Ruppert <christian.ruppert@abilis.com>,
linux-next <linux-next@vger.kernel.org>
Subject: Re: Removal of GENERIC_GPIO breaks -next
Date: Wed, 17 Apr 2013 17:37:31 +0530 [thread overview]
Message-ID: <516E9083.6050808@synopsys.com> (raw)
In-Reply-To: <CAAVeFu+fM=fJ2zp-gX4T07COMB31yvs74dXUqrw1LH09M7MXLg@mail.gmail.com>
On 04/17/2013 04:07 PM, Alexandre Courbot wrote:
>
> Also arch/arc/plat-tb10x/Kconfig now defines GENERIC_GPIO, this will
> not cause breakage but should not be here anymore (ideally removed by
> the "Remove GENERIC_GPIO config option" patch)
>
> Apart from these two issues, things seem to have gone fine, but I'm
> not sure how they should be addressed and by who?
For the arc issue - I thought we'd come to consensus already. Quoting your earlier
email:
"If the only reference to GENERIC_GPIO in your architecture or drivers is the
declaration of this config option, then it is perfectly fine - I will take care of
removing it when the time is right."
Anyhow it's a minor issue - since your code is in -next, maybe you can add the
following patch to your branch - rather than routing via my tree - better for
bisectablity. I compile tested here !
------------------->
From: Vineet Gupta <vgupta@synopsys.com>
Date: Wed, 17 Apr 2013 17:33:02 +0530
Subject: [PATCH] ARC: [TB10x] Remove GENERIC_GPIO
This tracks Alexandre Courbot's mainline GPIO rework
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
---
arch/arc/plat-tb10x/Kconfig | 7 -------
1 file changed, 7 deletions(-)
diff --git a/arch/arc/plat-tb10x/Kconfig b/arch/arc/plat-tb10x/Kconfig
index 4e12127..1d34521 100644
--- a/arch/arc/plat-tb10x/Kconfig
+++ b/arch/arc/plat-tb10x/Kconfig
@@ -27,10 +27,3 @@ menuconfig ARC_PLAT_TB10X
Abilis Systems. TB10x is based on the ARC700 CPU architecture.
Say Y if you are building a kernel for one of the SOCs in this
series (e.g. TB100 or TB101). If in doubt say N.
-
-if ARC_PLAT_TB10X
-
-config GENERIC_GPIO
- def_bool y
-
-endif
--
1.7.10.4
next prev parent reply other threads:[~2013-04-17 12:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 10:37 Removal of GENERIC_GPIO breaks -next Alexandre Courbot
2013-04-17 11:21 ` Christian Ruppert
2013-04-17 12:07 ` Vineet Gupta [this message]
2013-04-17 13:04 ` Alexandre Courbot
2013-04-17 13:16 ` Vineet Gupta
2013-04-18 7:18 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516E9083.6050808@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=christian.ruppert@abilis.com \
--cc=gnurou@gmail.com \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=shaveta@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).