From: Peter Hurley <peter@hurleysoftware.com>
To: Wang YanQing <udknight@gmail.com>, gregkh@linuxfoundation.org
Cc: sfr@canb.auug.org.au, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] TTY:vt: convert remain take_over_console's users to do_take_over_console
Date: Tue, 21 May 2013 09:10:33 -0400 [thread overview]
Message-ID: <519B7249.2070207@hurleysoftware.com> (raw)
In-Reply-To: <20130521051511.GA11435@udknight>
On 05/21/2013 01:15 AM, Wang YanQing wrote:
> Impact:
> 1:convert all remain take_over_console to do_take_over_console
> 2:update take_over_console to do_take_over_console in comment
>
> Commit dc9641895abb ("vt: delete unneeded functions
> register_con_driver|take_over_console") delete take_over_console,
> but forget to convert remain take_over_console's users to new API
> do_take_over_console, this patch fix it.
>
> Signed-off-by: Wang YanQing <udknight@gmail.com>
> ---
> Sorry for my mistake, I believe I do the full
> kernel source find|grep, but the reality is I
> forget take_over_console.
I would rather revert dc9641895abb which purported to delete
_unneeded_ functions than have this. Obviously the functions
were needed.
Regards,
Peter Hurley
next prev parent reply other threads:[~2013-05-21 13:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 5:15 [PATCH] TTY:vt: convert remain take_over_console's users to do_take_over_console Wang YanQing
2013-05-21 13:10 ` Peter Hurley [this message]
2013-05-21 14:42 ` Wang YanQing
2013-05-21 15:48 ` Peter Hurley
2013-05-21 16:18 ` Wang YanQing
2013-05-21 16:29 ` Wang YanQing
2013-05-21 17:45 ` Peter Hurley
2013-06-04 20:13 ` Pavel Machek
2013-06-06 1:23 ` Wang YanQing
2013-06-06 11:47 ` Pavel Machek
2013-06-06 14:22 ` Wang YanQing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519B7249.2070207@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).