From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH] TTY:vt: convert remain take_over_console's users to do_take_over_console Date: Tue, 21 May 2013 11:48:58 -0400 Message-ID: <519B976A.3050708@hurleysoftware.com> References: <20130521051511.GA11435@udknight> <519B7249.2070207@hurleysoftware.com> <20130521144215.GA5302@udknight.homenetwork> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout39.mail01.mtsvc.net ([216.70.64.83]:32977 "EHLO n12.mail01.mtsvc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753370Ab3EUPtE (ORCPT ); Tue, 21 May 2013 11:49:04 -0400 In-Reply-To: <20130521144215.GA5302@udknight.homenetwork> Sender: linux-next-owner@vger.kernel.org List-ID: To: Wang YanQing Cc: gregkh@linuxfoundation.org, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org On 05/21/2013 10:42 AM, Wang YanQing wrote: > On Tue, May 21, 2013 at 09:10:33AM -0400, Peter Hurley wrote: >> I would rather revert dc9641895abb which purported to delete >> _unneeded_ functions than have this. Obviously the functions >> were needed. >> > > Hi Peter, this series patches' goal is to reduce codes' > redundance and function duplication. But if we keep take_over_console, > then we have to rewrite it as a trivial wrapper over do_take_over_console, > or we have to keep bind_con_driver and register_con_driver, and this > will bring use codes' redundance. > > And if we rewrite take_over_console as a wrapper over > do_take_over_console, it is so trivial, delete it and let kernel > use the unified version of APIs will simplify the APIs. Except now you're spreading the brokenness that is console_lock() over many more source files than the single-use case of do_take_over_console(). The actual interface is take_over_console(); the _workaround_ is exposing do_take_over_console() for fbcon to wrap. Regards, Peter Hurley