From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver Date: Mon, 17 Jun 2013 10:49:16 -0600 Message-ID: <51BF3E0C.6050009@wwwdotorg.org> References: <1368476301-10495-1-git-send-email-linus.walleij@linaro.org> <51BF2FC5.40207@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij Cc: Wolfram Sang , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , Grant Likely , Rob Herring , "linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-next.vger.kernel.org On 06/17/2013 10:33 AM, Linus Walleij wrote: > On Mon, Jun 17, 2013 at 5:48 PM, Stephen Warren wrote: > >> This has just shown up in next-20130617, and breaks at least the >> TPS65910 and TPS62360 drivers, since they assume that the id parameter >> passed to probe is non-NULL. However, now the parameter is NULL since >> these drivers have both an ID table and an OF match table. > > So you mean they come in through the DT boot path and assume > that parameter is non-null even though they should not make use of > it? Yes. Since this wasn't true/enforced before, it probably wasn't clear that rule existed.