From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Gortmaker Subject: Re: [PATCH] lkdtm: include cacheflush.h Date: Fri, 21 Mar 2014 15:36:16 -0400 Message-ID: <532C94B0.9090602@windriver.com> References: <20140214235849.GA30703@www.outflux.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.windriver.com ([147.11.1.11]:53533 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745AbaCUTgM (ORCPT ); Fri, 21 Mar 2014 15:36:12 -0400 In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: Kees Cook , Greg Kroah-Hartman Cc: LKML , Fengguang Wu , Arnd Bergmann , "linux-next@vger.kernel.org" On 14-03-21 03:33 PM, Kees Cook wrote: > On Fri, Mar 21, 2014 at 12:31 PM, Paul Gortmaker > wrote: >> On Fri, Feb 14, 2014 at 6:58 PM, Kees Cook wrote: >>> Some architectures need cacheflush.h explicitly included (mips) for >>> use of flush_icache_range(): >>> >>> config: make ARCH=mips allmodconfig >>> All error/warnings: >>> >> ERROR: "flush_icache_range" undefined! >> >> The linux-next builds still fail with a similar error: >> >> http://kisskb.ellerman.id.au/kisskb/buildresult/10808358/ >> >> I'm not sure if it ever was a compile error, or if it was always >> a missing export symbol type error as it is apparently now. > > It seems no one picked up this fix? Greg, you normally take my lkdtm work... No, the "fix" is there, in linux-next, but it doesn't work. :) Paul. -- > > -Kees > >> >> Paul. >> -- >> >>> >>> Reported-by: Fengguang Wu >>> Signed-off-by: Kees Cook >>> --- >>> drivers/misc/lkdtm.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c >>> index 47ed2d321351..2ebd52e05773 100644 >>> --- a/drivers/misc/lkdtm.c >>> +++ b/drivers/misc/lkdtm.c >>> @@ -46,6 +46,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>> #ifdef CONFIG_IDE >>> #include >>> -- >>> 1.7.9.5 >>> >>> >>> -- >>> Kees Cook >>> Chrome OS Security >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> Please read the FAQ at http://www.tux.org/lkml/ > > >