From: Daniel Borkmann <dborkman@redhat.com>
To: "Vincent Stehlé" <vincent.stehle@laposte.net>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-next@vger.kernel.org
Subject: Re: [PATCH] cpts: Fix missing includes
Date: Sun, 06 Apr 2014 19:47:28 +0200 [thread overview]
Message-ID: <53419330.405@redhat.com> (raw)
In-Reply-To: <1396805660-9807-1-git-send-email-vincent.stehle@laposte.net>
On 04/06/2014 07:34 PM, Vincent Stehlé wrote:
> The ETH_HLEN and VLAN_HLEN definitions are not in if.h any more. Add the
> necessary includes to fix the following compilation errors:
>
> drivers/net/ethernet/ti/cpts.c: In function ‘cpts_match’:
> drivers/net/ethernet/ti/cpts.c:266:12: error: ‘ETH_HLEN’ undeclared (first use in this function)
> drivers/net/ethernet/ti/cpts.c:266:12: note: each undeclared identifier is reported only once for each function it appears in
> drivers/net/ethernet/ti/cpts.c:276:23: error: ‘VLAN_HLEN’ undeclared (first use in this function)
>
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
Thanks, fix is already in net tree ...
https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=79eb9d28c9b22fa419e2c3f1b2cc6e285720ae41
> diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
> index a3bbf59..2a2f82a 100644
> --- a/drivers/net/ethernet/ti/cpts.c
> +++ b/drivers/net/ethernet/ti/cpts.c
> @@ -19,6 +19,8 @@
> */
> #include <linux/err.h>
> #include <linux/if.h>
> +#include <linux/if_ether.h>
> +#include <linux/if_vlan.h>
> #include <linux/hrtimer.h>
> #include <linux/module.h>
> #include <linux/net_tstamp.h>
>
prev parent reply other threads:[~2014-04-06 17:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-06 17:34 [PATCH] cpts: Fix missing includes Vincent Stehlé
2014-04-06 17:47 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53419330.405@redhat.com \
--to=dborkman@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vincent.stehle@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).