From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Srivatsa S. Bhat" Subject: [PATCH] cpufreq, powernv: Fix build failure on UP Date: Wed, 16 Apr 2014 11:18:13 +0530 Message-ID: <534E199D.2090504@linux.vnet.ibm.com> References: <20140415141111.GA28352@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from e23smtp03.au.ibm.com ([202.81.31.145]:35989 "EHLO e23smtp03.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753169AbaDPFtF (ORCPT ); Wed, 16 Apr 2014 01:49:05 -0400 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 16 Apr 2014 15:49:03 +1000 In-Reply-To: <20140415141111.GA28352@windriver.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Paul Gortmaker , "Rafael J. Wysocki" Cc: ego@linux.vnet.ibm.com, svaidy@linux.vnet.ibm.com, preeti@linux.vnet.ibm.com, linux-next@vger.kernel.org, rafael.j.wysocki@intel.com, Viresh Kumar , cpufreq , Linux PM mailing list , "linux-kernel@vger.kernel.org" On 04/15/2014 07:41 PM, Paul Gortmaker wrote: > Hi all, > > This new driver is causing build fails on linux-next for non-SMP. > > http://kisskb.ellerman.id.au/kisskb/buildresult/10911507/ > > I didn't bisect since there are only two commits in total. :) > > Looks like some header foo where is not getting > Hi Paul, Thanks a lot for reporting the build failure. Please find the fix below. Regards, Srivatsa S. Bhat --------------------------------------------------------------------------- From: Srivatsa S. Bhat Subject: [PATCH] cpufreq, powernv: Fix build failure on UP Paul Gortmaker reported the following build failure of the powernv cpufreq driver on UP configs: drivers/cpufreq/powernv-cpufreq.c:241:2: error: implicit declaration of function 'cpu_sibling_mask' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors make[3]: *** [drivers/cpufreq/powernv-cpufreq.o] Error 1 make[2]: *** [drivers/cpufreq] Error 2 make[1]: *** [drivers] Error 2 make: *** [sub-make] Error 2 The trouble here is that cpu_sibling_mask is defined only in , and includes only in SMP builds. So fix this build failure by explicitly including in the driver, so that we get the definition of cpu_sibling_mask even in UP configurations. Reported-by: Paul Gortmaker Signed-off-by: Srivatsa S. Bhat --- drivers/cpufreq/powernv-cpufreq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index 9edccc6..ed1c7e5 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -29,6 +29,7 @@ #include #include +#include #define POWERNV_MAX_PSTATES 256