From: Randy Dunlap <rdunlap@infradead.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Hurley <peter@hurleysoftware.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: [PATCH] serial: imx: Fix build breakage
Date: Fri, 11 Jul 2014 19:00:48 -0700 [thread overview]
Message-ID: <53C096D0.3000005@infradead.org> (raw)
In-Reply-To: <20140712004248.GA24760@kroah.com>
On 07/11/14 17:42, Greg Kroah-Hartman wrote:
> On Thu, Jul 10, 2014 at 10:36:46PM -0400, Peter Hurley wrote:
>> Fix breakage introduced by
>> commit c557d392fbf5badd693ea1946a4317c87a26a716,
>> 'serial: Test for no tx data on tx restart'.
>>
>> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
>
> You forgot a "Reported-by:" tag.
>
> I'll go add it...
It's not clear to me that Peter forgot it.
Someone else brought this up -- it seems to me that
Documentation/SubmittingPatches is a little too strong about needing
permission to use Reported-by:
If this patch fixes a problem reported by somebody else, consider adding a
Reported-by: tag to credit the reporter for their contribution. Please
note that this tag should not be added without the reporter's permission,
especially if the problem was not reported in a public forum. That said,
if we diligently credit our bug reporters, they will, hopefully, be
inspired to help us again in the future.
Sure, if a problem was reported privately, then we need to have permission
to use Reported-by, but if it was reported in a public forum, that should be
implicit permission (IMHO).
eh?
--
~Randy
next prev parent reply other threads:[~2014-07-12 2:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 1:21 linux-next: build failure after merge of the tty.current tree Stephen Rothwell
2014-07-11 2:36 ` [PATCH] serial: imx: Fix build breakage Peter Hurley
2014-07-12 0:42 ` Greg Kroah-Hartman
2014-07-12 2:00 ` Randy Dunlap [this message]
2014-07-12 2:09 ` Stephen Rothwell
2014-07-12 2:16 ` Greg Kroah-Hartman
2014-07-12 2:39 ` Randy Dunlap
2014-07-12 13:11 ` Peter Hurley
2014-07-11 15:06 ` linux-next: build failure after merge of the tty.current tree Peter Hurley
2014-07-12 1:20 ` Stephen Rothwell
2014-07-12 13:02 ` Peter Hurley
2014-07-15 17:49 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C096D0.3000005@infradead.org \
--to=rdunlap@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).