From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH] regmap: fix of_regmap_get_endian() Date: Tue, 19 Aug 2014 10:14:45 -0600 Message-ID: <53F377F5.4080304@wwwdotorg.org> References: <1408400044-2560-1-git-send-email-swarren@wwwdotorg.org> <20140819153451.GB24407@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from avon.wwwdotorg.org ([70.85.31.133]:36217 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752244AbaHSQO0 (ORCPT ); Tue, 19 Aug 2014 12:14:26 -0400 In-Reply-To: <20140819153451.GB24407@sirena.org.uk> Sender: linux-next-owner@vger.kernel.org List-ID: To: Mark Brown Cc: Thierry Reding , linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, Stephen Warren , Xiubo Li On 08/19/2014 09:34 AM, Mark Brown wrote: > On Mon, Aug 18, 2014 at 04:14:04PM -0600, Stephen Warren wrote: >> From: Stephen Warren >> >> Commit d647c199510c ("regmap: add DT endianness binding support") has >> some issues. Specifically, if config->reg_format_endian is not explicitly >> set, it will be zero, i.e. REGMAP_ENDIAN_DEFAULT. The switch statement > > Please respin this against current code, as Xiubo said Javier fixed some > of this already. Sure. For some reason, my email client's search for of_regmap_get_endian didn't find the message even though that word is part of it:-/