From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiang Liu Subject: Re: linux-next: Tree for Nov 14 Date: Sun, 16 Nov 2014 16:24:25 +0800 Message-ID: <54685F39.3060007@linux.intel.com> References: <20141114192738.08e744cc@canb.auug.org.au> <20141115211922.GA2347@roeck-us.net> <54680D0A.7070900@linux.intel.com> <5468185D.5020400@roeck-us.net> <54682618.1070508@linux.intel.com> <54684A9E.90606@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com ([134.134.136.65]:33977 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752093AbaKPIY3 (ORCPT ); Sun, 16 Nov 2014 03:24:29 -0500 In-Reply-To: <54684A9E.90606@roeck-us.net> Sender: linux-next-owner@vger.kernel.org List-ID: To: Guenter Roeck , Stephen Rothwell Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner On 2014/11/16 14:56, Guenter Roeck wrote: > On 11/15/2014 08:20 PM, Jiang Liu wrote: >> >> On 2014/11/16 11:22, Guenter Roeck wrote: >>> On 11/15/2014 06:33 PM, Jiang Liu wrote: >>>> Hi Guenter, >>>> Could you please help to provide the config file and >>>> error messages? >>> >>> Config file: >>> >>> https://github.com/groeck/linux-build-test/blob/master/rootfs/x86/qemu_x86_pc_nosmp_defconfig >>> >> Hi Guenter, >> Thanks for help. According to the above configuration file: >> CONFIG_PCI_MSI is enabled, but CONFIG_X86_LOCAL_APIC and >> CONFIG_X86_IO_APIC are both disabled. But the Kconfig for X86_LOCAL_APIC >> is defined as: >> config X86_LOCAL_APIC >> def_bool y >> depends on X86_64 || SMP || X86_32_NON_STANDARD || X86_UP_APIC >> || PCI_MSI >> select GENERIC_IRQ_LEGACY_ALLOC_HWIRQ >> >> That means CONFIG_X86_LOCAL_APIC should be enabled if CONFIG_PCI_MSI is >> enabled. So how did you generate the qemu_x86_pc_nosmp_defconfig? Are >> you using an old configuration file? > > I took the configuration file I had for the SMP case (located in the same > directory in the git repository), disabled SMP, and ran "make > savedefconfig". > "old" is relative in this context; I don't usually create new configuration > files for each new kernel release, so, yes, you could say that the file > I used is "old". > > CONFIG_X86_LOCAL_APIC is enabled. Keep in mind this is a configuration file > created with "make savedefconfig", so default settings are not included. > Correct, CONFIG_X86_IO_APIC is not enabled, but that is not really > surprising > since its dependencies are not met as far as I can see. > > Overall, I am not sure I understand what you are trying to say. X86_IO_APIC > depends on X86_64 (not set) or SMP (not set) or X86_32_NON_STANDARD (not > set) > or X86_UP_IOAPIC (not set because it depends on X86_UP_APIC which > depends on > !PCI_MSI). > > Does that mean that I'll have to disable PCI_MSI to get x86 uniprocessor > support to work after your patch ? Hi Guenter, Previously, X86_IO_APIC will be enabled if PCI_MSI is enabled. With my patch, x86_IO_APIC may be disabled even if PCI_MSI is enabled. If X86_LOCAL_APIC/PCI_MSI are enabled and X86_IO_APIC is disabled, it should work theoretically. I remember it works on my HP laptop. Could you please help to check whether it solve the issue by manually turning on X86_IO_APIC? Thanks! Gerry > > Thanks, > Guenter >