* [PATCH] media: pci: smipcie: Fix dependency for DVB_SMIPCIE
@ 2014-11-21 17:51 Andreas Ruprecht
2014-11-21 18:13 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Ruprecht @ 2014-11-21 17:51 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: linux-media, linux-kernel, linux-next, sfr, Andreas Ruprecht
In smipcie.c, the function i2c_bit_add_bus() is called. This
function is defined by the I2C bit-banging interfaces enabled
with CONFIG_I2C_ALGOBIT.
As there was no dependency in Kconfig, CONFIG_I2C_ALGOBIT could
be set to "m" while CONFIG_DVB_SMIPCIE was set to "y", resulting
in a build error due to an undefined reference. This patch adds
the dependency on CONFIG_I2C_ALGOBIT in Kconfig.
Signed-off-by: Andreas Ruprecht <rupran@einserver.de>
Reported-by: Jim Davis <jim.epost@gmail.com>
---
drivers/media/pci/smipcie/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/smipcie/Kconfig b/drivers/media/pci/smipcie/Kconfig
index 75a2992..c728721 100644
--- a/drivers/media/pci/smipcie/Kconfig
+++ b/drivers/media/pci/smipcie/Kconfig
@@ -1,6 +1,6 @@
config DVB_SMIPCIE
tristate "SMI PCIe DVBSky cards"
- depends on DVB_CORE && PCI && I2C
+ depends on DVB_CORE && PCI && I2C && I2C_ALGOBIT
select DVB_M88DS3103 if MEDIA_SUBDRV_AUTOSELECT
select MEDIA_TUNER_M88TS2022 if MEDIA_SUBDRV_AUTOSELECT
select MEDIA_TUNER_M88RS6000T if MEDIA_SUBDRV_AUTOSELECT
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] media: pci: smipcie: Fix dependency for DVB_SMIPCIE
2014-11-21 17:51 [PATCH] media: pci: smipcie: Fix dependency for DVB_SMIPCIE Andreas Ruprecht
@ 2014-11-21 18:13 ` Mauro Carvalho Chehab
2014-11-21 18:15 ` Andreas Ruprecht
2014-11-21 18:23 ` [PATCH v2] " Andreas Ruprecht
0 siblings, 2 replies; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2014-11-21 18:13 UTC (permalink / raw)
To: Andreas Ruprecht; +Cc: linux-media, linux-kernel, linux-next, sfr
Em Fri, 21 Nov 2014 18:51:59 +0100
Andreas Ruprecht <rupran@einserver.de> escreveu:
> In smipcie.c, the function i2c_bit_add_bus() is called. This
> function is defined by the I2C bit-banging interfaces enabled
> with CONFIG_I2C_ALGOBIT.
>
> As there was no dependency in Kconfig, CONFIG_I2C_ALGOBIT could
> be set to "m" while CONFIG_DVB_SMIPCIE was set to "y", resulting
> in a build error due to an undefined reference. This patch adds
> the dependency on CONFIG_I2C_ALGOBIT in Kconfig.
>
> Signed-off-by: Andreas Ruprecht <rupran@einserver.de>
> Reported-by: Jim Davis <jim.epost@gmail.com>
> ---
> drivers/media/pci/smipcie/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/smipcie/Kconfig b/drivers/media/pci/smipcie/Kconfig
> index 75a2992..c728721 100644
> --- a/drivers/media/pci/smipcie/Kconfig
> +++ b/drivers/media/pci/smipcie/Kconfig
> @@ -1,6 +1,6 @@
> config DVB_SMIPCIE
> tristate "SMI PCIe DVBSky cards"
> - depends on DVB_CORE && PCI && I2C
> + depends on DVB_CORE && PCI && I2C && I2C_ALGOBIT
IMHO, the best would be, instead, to select I2C_ALGOBIT.
> select DVB_M88DS3103 if MEDIA_SUBDRV_AUTOSELECT
> select MEDIA_TUNER_M88TS2022 if MEDIA_SUBDRV_AUTOSELECT
> select MEDIA_TUNER_M88RS6000T if MEDIA_SUBDRV_AUTOSELECT
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: pci: smipcie: Fix dependency for DVB_SMIPCIE
2014-11-21 18:13 ` Mauro Carvalho Chehab
@ 2014-11-21 18:15 ` Andreas Ruprecht
2014-11-21 18:23 ` [PATCH v2] " Andreas Ruprecht
1 sibling, 0 replies; 4+ messages in thread
From: Andreas Ruprecht @ 2014-11-21 18:15 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media, linux-kernel, linux-next, sfr
On 21.11.2014 19:13, Mauro Carvalho Chehab wrote:
> Em Fri, 21 Nov 2014 18:51:59 +0100
> Andreas Ruprecht <rupran@einserver.de> escreveu:
>
>> In smipcie.c, the function i2c_bit_add_bus() is called. This
>> function is defined by the I2C bit-banging interfaces enabled
>> with CONFIG_I2C_ALGOBIT.
>>
>> As there was no dependency in Kconfig, CONFIG_I2C_ALGOBIT could
>> be set to "m" while CONFIG_DVB_SMIPCIE was set to "y", resulting
>> in a build error due to an undefined reference. This patch adds
>> the dependency on CONFIG_I2C_ALGOBIT in Kconfig.
>>
>> Signed-off-by: Andreas Ruprecht <rupran@einserver.de>
>> Reported-by: Jim Davis <jim.epost@gmail.com>
>> ---
>> drivers/media/pci/smipcie/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/pci/smipcie/Kconfig b/drivers/media/pci/smipcie/Kconfig
>> index 75a2992..c728721 100644
>> --- a/drivers/media/pci/smipcie/Kconfig
>> +++ b/drivers/media/pci/smipcie/Kconfig
>> @@ -1,6 +1,6 @@
>> config DVB_SMIPCIE
>> tristate "SMI PCIe DVBSky cards"
>> - depends on DVB_CORE && PCI && I2C
>> + depends on DVB_CORE && PCI && I2C && I2C_ALGOBIT
>
> IMHO, the best would be, instead, to select I2C_ALGOBIT.
Okay, I'll change that and submit a new version of this patch.
Regards,
Andreas Ruprecht
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] media: pci: smipcie: Fix dependency for DVB_SMIPCIE
2014-11-21 18:13 ` Mauro Carvalho Chehab
2014-11-21 18:15 ` Andreas Ruprecht
@ 2014-11-21 18:23 ` Andreas Ruprecht
1 sibling, 0 replies; 4+ messages in thread
From: Andreas Ruprecht @ 2014-11-21 18:23 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: linux-media, linux-kernel, linux-next, sfr, Andreas Ruprecht
In smipcie.c, the function i2c_bit_add_bus() is called. This
function is defined by the I2C bit-banging interfaces enabled
with CONFIG_I2C_ALGOBIT.
As there was no dependency in Kconfig, CONFIG_I2C_ALGOBIT could
be set to "m" while CONFIG_DVB_SMIPCIE was set to "y", resulting
in a build error due to an undefined reference.
This patch adds the dependency on CONFIG_I2C_ALGOBIT in Kconfig
by selecting it when CONFIG_DVB_SMIPCIE is selected.
Signed-off-by: Andreas Ruprecht <rupran@einserver.de>
Reported-by: Jim Davis <jim.epost@gmail.com>
---
drivers/media/pci/smipcie/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/pci/smipcie/Kconfig b/drivers/media/pci/smipcie/Kconfig
index 75a2992..57dd124 100644
--- a/drivers/media/pci/smipcie/Kconfig
+++ b/drivers/media/pci/smipcie/Kconfig
@@ -1,6 +1,7 @@
config DVB_SMIPCIE
tristate "SMI PCIe DVBSky cards"
depends on DVB_CORE && PCI && I2C
+ select I2C_ALGOBIT
select DVB_M88DS3103 if MEDIA_SUBDRV_AUTOSELECT
select MEDIA_TUNER_M88TS2022 if MEDIA_SUBDRV_AUTOSELECT
select MEDIA_TUNER_M88RS6000T if MEDIA_SUBDRV_AUTOSELECT
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-21 18:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-21 17:51 [PATCH] media: pci: smipcie: Fix dependency for DVB_SMIPCIE Andreas Ruprecht
2014-11-21 18:13 ` Mauro Carvalho Chehab
2014-11-21 18:15 ` Andreas Ruprecht
2014-11-21 18:23 ` [PATCH v2] " Andreas Ruprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).