From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the access_once tree
Date: Wed, 10 Dec 2014 12:20:35 +0100 [thread overview]
Message-ID: <54882C83.5010803@de.ibm.com> (raw)
In-Reply-To: <20141210192035.2e5d80ff@canb.auug.org.au>
Am 10.12.2014 um 09:20 schrieb Stephen Rothwell:
> Hi Christian,
>
> After merging the access_once tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
>
> In file included from /scratch/sfr/next/include/uapi/linux/stddef.h:1:0,
> from /scratch/sfr/next/include/linux/stddef.h:4,
> from /scratch/sfr/next/include/uapi/linux/posix_types.h:4,
> from /scratch/sfr/next/include/uapi/linux/types.h:13,
> from /scratch/sfr/next/include/linux/types.h:5,
> from /scratch/sfr/next/include/linux/smp.h:10,
> from /scratch/sfr/next/include/linux/kernel_stat.h:4,
> from /scratch/sfr/next/mm/memory.c:41:
> In function '__read_once_size',
> inlined from 'handle_pte_fault' at /scratch/sfr/next/mm/memory.c:3192:10,
> inlined from '__handle_mm_fault' at /scratch/sfr/next/mm/memory.c:3324:2,
> inlined from 'handle_mm_fault' at /scratch/sfr/next/mm/memory.c:3353:6:
> /scratch/sfr/next/include/linux/compiler.h:206:3: warning: call to 'data_access_exceeds_word_size' declared with attribute warning: data access exceeds word size and won't be atomic
> data_access_exceeds_word_size();
> ^
> mm/built-in.o: In function `handle_mm_fault':
> (.text+0x283a0): undefined reference to `data_access_exceeds_word_size'
>
> I hate dropped the access_once tree again today.
hate dropped? typo or bad mood? ;-)
I fixed this two-ways
1: a real bug: I did not provide data_access_exceeds_word_size
2: a change in semantics: change the memory.c rework to a barrier as if should be enough
Can you retry (I added ppc44x_defconfig to my cross compile test)?
Christian
Sorry for being such a pain, but the access_once rework will be prone to compile errors
next prev parent reply other threads:[~2014-12-10 11:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 8:20 linux-next: build failure after merge of the access_once tree Stephen Rothwell
2014-12-10 11:20 ` Christian Borntraeger [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-08 11:26 Stephen Rothwell
2014-12-08 11:35 ` Christian Borntraeger
2014-12-09 19:54 ` Christian Borntraeger
2014-12-05 10:32 Stephen Rothwell
2014-12-07 20:57 ` Christian Borntraeger
2014-12-07 21:16 ` Christian Borntraeger
2014-12-07 23:55 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54882C83.5010803@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).