linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] exynos/drm: fix no hdmi output
@ 2015-01-29 21:18 Alban Browaeys
  2015-01-30  0:24 ` Joonyoung Shim
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Alban Browaeys @ 2015-01-29 21:18 UTC (permalink / raw)
  To: Gustavo Padovan, Inki Dae, Joonyoung Shim, Seung-Woo Kim,
	Kyungmin Park
  Cc: linux-samsung-soc, linux-next, Alban Browaeys

The hdmi outputs black screen only even though under the hood Xorg and
framebuffer console  are fine : devices found and initialized, but
not a pixel out.

Commit 93bca243ec96 ("drm/exynos: remove struct exynos_drm_manager")
changed the call order of mixer_initialize with regards to
 exynos_drm_crtc_create.

This changes breaks hdmi out on Odroid U2 (linux-next with added
 Marek Szyprowski v4 hdmi patchset from linux-samsung-soc ML).

Restore the previous call ordering get hdmi to ouput proper pixels:
ie call mixer_initialize first then exynos_drm_crtc_create.

Fixes: 93bca243ec96 ("drm/exynos: remove struct exynos_drm_manager")
Signed-off-by: Alban Browaeys <prahal@yahoo.com>
---
 drivers/gpu/drm/exynos/exynos_mixer.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
index d8fd8e1..188f90f 100644
--- a/drivers/gpu/drm/exynos/exynos_mixer.c
+++ b/drivers/gpu/drm/exynos/exynos_mixer.c
@@ -1258,18 +1258,19 @@ static int mixer_bind(struct device *dev, struct device *manager, void *data)
 	struct drm_device *drm_dev = data;
 	int ret;
 
+	ret = mixer_initialize(ctx, drm_dev);
+	if (ret)
+		return ret;
+
 	ctx->crtc = exynos_drm_crtc_create(drm_dev, ctx->pipe,
 				     EXYNOS_DISPLAY_TYPE_HDMI,
 				     &mixer_crtc_ops, ctx);
 	if (IS_ERR(ctx->crtc)) {
+		mixer_ctx_remove(ctx);
 		ret = PTR_ERR(ctx->crtc);
 		goto free_ctx;
 	}
 
-	ret = mixer_initialize(ctx, drm_dev);
-	if (ret)
-		goto free_ctx;
-
 	return 0;
 
 free_ctx:
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] exynos/drm: fix no hdmi output
  2015-01-29 21:18 [PATCH] exynos/drm: fix no hdmi output Alban Browaeys
@ 2015-01-30  0:24 ` Joonyoung Shim
  2015-01-30  7:29   ` Joonyoung Shim
  2015-01-30 14:55 ` Gustavo Padovan
  2015-02-04  8:35 ` Inki Dae
  2 siblings, 1 reply; 5+ messages in thread
From: Joonyoung Shim @ 2015-01-30  0:24 UTC (permalink / raw)
  To: Alban Browaeys, Gustavo Padovan, Inki Dae, Seung-Woo Kim,
	Kyungmin Park
  Cc: linux-samsung-soc, linux-next, dri-devel@lists.freedesktop.org

+Cc dri-devel ML.

Hi Alban,

On 01/30/2015 06:18 AM, Alban Browaeys wrote:
> The hdmi outputs black screen only even though under the hood Xorg and
> framebuffer console  are fine : devices found and initialized, but
> not a pixel out.
> 
> Commit 93bca243ec96 ("drm/exynos: remove struct exynos_drm_manager")
> changed the call order of mixer_initialize with regards to
>  exynos_drm_crtc_create.
> 

Right, there is no any reason to change order but i don't think it
causes problem because they don't any dependency.

> This changes breaks hdmi out on Odroid U2 (linux-next with added
>  Marek Szyprowski v4 hdmi patchset from linux-samsung-soc ML).
> 

I tested Odroid U3 but hdmi out is working well.

Thanks.

> Restore the previous call ordering get hdmi to ouput proper pixels:
> ie call mixer_initialize first then exynos_drm_crtc_create.
> 
> Fixes: 93bca243ec96 ("drm/exynos: remove struct exynos_drm_manager")
> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
> ---
>  drivers/gpu/drm/exynos/exynos_mixer.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
> index d8fd8e1..188f90f 100644
> --- a/drivers/gpu/drm/exynos/exynos_mixer.c
> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c
> @@ -1258,18 +1258,19 @@ static int mixer_bind(struct device *dev, struct device *manager, void *data)
>  	struct drm_device *drm_dev = data;
>  	int ret;
>  
> +	ret = mixer_initialize(ctx, drm_dev);
> +	if (ret)
> +		return ret;
> +
>  	ctx->crtc = exynos_drm_crtc_create(drm_dev, ctx->pipe,
>  				     EXYNOS_DISPLAY_TYPE_HDMI,
>  				     &mixer_crtc_ops, ctx);
>  	if (IS_ERR(ctx->crtc)) {
> +		mixer_ctx_remove(ctx);
>  		ret = PTR_ERR(ctx->crtc);
>  		goto free_ctx;
>  	}
>  
> -	ret = mixer_initialize(ctx, drm_dev);
> -	if (ret)
> -		goto free_ctx;
> -
>  	return 0;
>  
>  free_ctx:
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] exynos/drm: fix no hdmi output
  2015-01-30  0:24 ` Joonyoung Shim
@ 2015-01-30  7:29   ` Joonyoung Shim
  0 siblings, 0 replies; 5+ messages in thread
From: Joonyoung Shim @ 2015-01-30  7:29 UTC (permalink / raw)
  To: Alban Browaeys, Gustavo Padovan, Inki Dae, Seung-Woo Kim,
	Kyungmin Park
  Cc: linux-samsung-soc, linux-next, dri-devel@lists.freedesktop.org

Hi,

On 01/30/2015 09:24 AM, Joonyoung Shim wrote:
> +Cc dri-devel ML.
> 
> Hi Alban,
> 
> On 01/30/2015 06:18 AM, Alban Browaeys wrote:
>> The hdmi outputs black screen only even though under the hood Xorg and
>> framebuffer console  are fine : devices found and initialized, but
>> not a pixel out.
>>
>> Commit 93bca243ec96 ("drm/exynos: remove struct exynos_drm_manager")
>> changed the call order of mixer_initialize with regards to
>>  exynos_drm_crtc_create.
>>
> 
> Right, there is no any reason to change order but i don't think it
> causes problem because they don't any dependency.
> 

OK, i also get blank screen from hdmi after enable vidi.

>> This changes breaks hdmi out on Odroid U2 (linux-next with added
>>  Marek Szyprowski v4 hdmi patchset from linux-samsung-soc ML).
>>
> 
> I tested Odroid U3 but hdmi out is working well.
> 
> Thanks.
> 
>> Restore the previous call ordering get hdmi to ouput proper pixels:
>> ie call mixer_initialize first then exynos_drm_crtc_create.
>>
>> Fixes: 93bca243ec96 ("drm/exynos: remove struct exynos_drm_manager")
>> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
>> ---
>>  drivers/gpu/drm/exynos/exynos_mixer.c | 9 +++++----
>>  1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
>> index d8fd8e1..188f90f 100644
>> --- a/drivers/gpu/drm/exynos/exynos_mixer.c
>> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c
>> @@ -1258,18 +1258,19 @@ static int mixer_bind(struct device *dev, struct device *manager, void *data)
>>  	struct drm_device *drm_dev = data;
>>  	int ret;
>>  
>> +	ret = mixer_initialize(ctx, drm_dev);
>> +	if (ret)
>> +		return ret;
>> +

The pipe value for crtc is increased in mixer_initialize so it should be
called before exynos_drm_crtc_create because the pipe value is used in
exynos_drm_crtc_create.

Acked-by: Joonyoung Shim <jy0922.shim@samsung.com>

Fimd and VIDI driver also have same issue. I will post the patch to fix
this for Fimd and VIDI driver.

Thanks.

>>  	ctx->crtc = exynos_drm_crtc_create(drm_dev, ctx->pipe,
>>  				     EXYNOS_DISPLAY_TYPE_HDMI,
>>  				     &mixer_crtc_ops, ctx);
>>  	if (IS_ERR(ctx->crtc)) {
>> +		mixer_ctx_remove(ctx);
>>  		ret = PTR_ERR(ctx->crtc);
>>  		goto free_ctx;
>>  	}
>>  
>> -	ret = mixer_initialize(ctx, drm_dev);
>> -	if (ret)
>> -		goto free_ctx;
>> -
>>  	return 0;
>>  
>>  free_ctx:
>>
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] exynos/drm: fix no hdmi output
  2015-01-29 21:18 [PATCH] exynos/drm: fix no hdmi output Alban Browaeys
  2015-01-30  0:24 ` Joonyoung Shim
@ 2015-01-30 14:55 ` Gustavo Padovan
  2015-02-04  8:35 ` Inki Dae
  2 siblings, 0 replies; 5+ messages in thread
From: Gustavo Padovan @ 2015-01-30 14:55 UTC (permalink / raw)
  To: Alban Browaeys
  Cc: Gustavo Padovan, Inki Dae, Joonyoung Shim, Seung-Woo Kim,
	Kyungmin Park, linux-samsung-soc, linux-next, Alban Browaeys

Hi Alban,

2015-01-29 Alban Browaeys <alban.browaeys@gmail.com>:

> The hdmi outputs black screen only even though under the hood Xorg and
> framebuffer console  are fine : devices found and initialized, but
> not a pixel out.
> 
> Commit 93bca243ec96 ("drm/exynos: remove struct exynos_drm_manager")
> changed the call order of mixer_initialize with regards to
>  exynos_drm_crtc_create.
> 
> This changes breaks hdmi out on Odroid U2 (linux-next with added
>  Marek Szyprowski v4 hdmi patchset from linux-samsung-soc ML).
> 
> Restore the previous call ordering get hdmi to ouput proper pixels:
> ie call mixer_initialize first then exynos_drm_crtc_create.
> 
> Fixes: 93bca243ec96 ("drm/exynos: remove struct exynos_drm_manager")
> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
> ---
>  drivers/gpu/drm/exynos/exynos_mixer.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

	Gustavo

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] exynos/drm: fix no hdmi output
  2015-01-29 21:18 [PATCH] exynos/drm: fix no hdmi output Alban Browaeys
  2015-01-30  0:24 ` Joonyoung Shim
  2015-01-30 14:55 ` Gustavo Padovan
@ 2015-02-04  8:35 ` Inki Dae
  2 siblings, 0 replies; 5+ messages in thread
From: Inki Dae @ 2015-02-04  8:35 UTC (permalink / raw)
  To: Alban Browaeys
  Cc: Gustavo Padovan, Joonyoung Shim, Seung-Woo Kim, Kyungmin Park,
	linux-samsung-soc, linux-next, Alban Browaeys

Hi,

On 2015년 01월 30일 06:18, Alban Browaeys wrote:
> The hdmi outputs black screen only even though under the hood Xorg and
> framebuffer console  are fine : devices found and initialized, but
> not a pixel out.
> 
> Commit 93bca243ec96 ("drm/exynos: remove struct exynos_drm_manager")
> changed the call order of mixer_initialize with regards to
>  exynos_drm_crtc_create.
> 
> This changes breaks hdmi out on Odroid U2 (linux-next with added
>  Marek Szyprowski v4 hdmi patchset from linux-samsung-soc ML).
> 
> Restore the previous call ordering get hdmi to ouput proper pixels:
> ie call mixer_initialize first then exynos_drm_crtc_create.

Applied. Please use prefix of subject correctly, drm/exynos because your
patch is filtered in my mail box.

Thanks,
Inki Dae

> 
> Fixes: 93bca243ec96 ("drm/exynos: remove struct exynos_drm_manager")
> Signed-off-by: Alban Browaeys <prahal@yahoo.com>
> ---
>  drivers/gpu/drm/exynos/exynos_mixer.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
> index d8fd8e1..188f90f 100644
> --- a/drivers/gpu/drm/exynos/exynos_mixer.c
> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c
> @@ -1258,18 +1258,19 @@ static int mixer_bind(struct device *dev, struct device *manager, void *data)
>  	struct drm_device *drm_dev = data;
>  	int ret;
>  
> +	ret = mixer_initialize(ctx, drm_dev);
> +	if (ret)
> +		return ret;
> +
>  	ctx->crtc = exynos_drm_crtc_create(drm_dev, ctx->pipe,
>  				     EXYNOS_DISPLAY_TYPE_HDMI,
>  				     &mixer_crtc_ops, ctx);
>  	if (IS_ERR(ctx->crtc)) {
> +		mixer_ctx_remove(ctx);
>  		ret = PTR_ERR(ctx->crtc);
>  		goto free_ctx;
>  	}
>  
> -	ret = mixer_initialize(ctx, drm_dev);
> -	if (ret)
> -		goto free_ctx;
> -
>  	return 0;
>  
>  free_ctx:
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-02-04  8:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-29 21:18 [PATCH] exynos/drm: fix no hdmi output Alban Browaeys
2015-01-30  0:24 ` Joonyoung Shim
2015-01-30  7:29   ` Joonyoung Shim
2015-01-30 14:55 ` Gustavo Padovan
2015-02-04  8:35 ` Inki Dae

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).