From: Hans de Goede <hdegoede@redhat.com>
To: Yann Droneaud <ydroneaud@opteya.com>,
Gregory CLEMENT <gregory.clement@free-electrons.com>,
Tejun Heo <tj@kernel.org>
Cc: linux-next@vger.kernel.org, linux-ide@vger.kernel.org,
sparclinux@vger.kernel.org
Subject: Re: linux-next: libahci_platform has undefined symbol on sparc
Date: Sat, 31 Jan 2015 17:25:43 +0100 [thread overview]
Message-ID: <54CD0207.2090306@redhat.com> (raw)
In-Reply-To: <1422710050.3030.17.camel@opteya.com>
Hi,
On 01/31/2015 02:14 PM, Yann Droneaud wrote:
> Hi,
>
> I've seen another issue regarding commit c7d7ddee7e24eedde6149eefbcfbfbc7125b9ff0
> ("ata: libahci: Allow using multiple regulators") from linux-next:
> This commit modify ahci_platform_get_resources to use of_platform_device_create().
>
> Unfortunately, it seems that of_platform_device_create() is not
> available on sparc (see CONFIG_OF_ADDRESS), so when built for sparc,
> the module libahci_platform.ko is rejected by modpost:
>
> ERROR: "of_platform_device_create" [drivers/ata/libahci_platform.ko] undefined!
> ../scripts/Makefile.modpost:91: recipe for target '__modpost' failed
> make[2]: *** [__modpost] Error 1
> src/linux/Makefile:1120: recipe for target 'modules' failed
Ah yes we had the same problem in simplefb, the example code for using
of_platform_device came from simplefb, and already had the fix, but it look
like Gregory did not include the bits fixing this in the ahci_platform code
Gregory, can you please submit a follow up patch fixing this? See simplefb.c
for the easiest way to fix this.
Regards,
Hans
next prev parent reply other threads:[~2015-01-31 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 13:14 linux-next: libahci_platform has undefined symbol on sparc Yann Droneaud
2015-01-31 16:25 ` Hans de Goede [this message]
2015-01-31 16:38 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CD0207.2090306@redhat.com \
--to=hdegoede@redhat.com \
--cc=gregory.clement@free-electrons.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=tj@kernel.org \
--cc=ydroneaud@opteya.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).