From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [PATCH] clocksource: make ARM_TIMER_SP804 depend on GENERIC_SCHED_CLOCK Date: Fri, 29 May 2015 12:33:31 +0100 Message-ID: <55684E8B.1080404@arm.com> References: <20150529110919.2276365a@canb.auug.org.au> <1432887476-19301-1-git-send-email-sudeep.holla@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from foss.arm.com ([217.140.101.70]:57358 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751995AbbE2Ldf (ORCPT ); Fri, 29 May 2015 07:33:35 -0400 In-Reply-To: <1432887476-19301-1-git-send-email-sudeep.holla@arm.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: "linux-kernel@vger.kernel.org" , Russell King , "linux-arm-kernel@lists.infradead.org" Cc: Sudeep Holla , "linux-next@vger.kernel.org" , Stephen Rothwell , Daniel Lezcano , Thomas Gleixner On 29/05/15 09:17, Sudeep Holla wrote: > Commit 5261ef2ea836 ("ARM: 8366/1: move Dual-Timer SP804 driver to > drivers/clocksource") moved SP804 to drivers/clocksource resulting in > it being selectable on platforms/architectures without the config > GENERIC_SCHED_CLOCK enabled. Due to that, it results in the following > build failure(e.g. x86_64 allmodconfig) > > drivers/built-in.o: In function `__sp804_clocksource_and_sched_clock_init': > (.init.text+0x1a0e7): undefined reference to `sched_clock_register' > > This patch fixes the build by making ARM_TIMER_SP804 depend on > GENERIC_SCHED_CLOCK > > Cc: Stephen Rothwell > Cc: Russell King > Cc: Daniel Lezcano > Cc: Thomas Gleixner > Signed-off-by: Sudeep Holla > --- > drivers/clocksource/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > Hi Russell, > > If you are fine with this fix, I will put this into the patch tracker. > I have put this in patch tracker (8382/1)[1] Regards, Sudeep [1] http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=8382/1