* next-20150609 build: 2 failures 40 warnings (next-20150609)
@ 2015-06-09 18:09 Build bot for Mark Brown
2015-06-09 18:23 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Build bot for Mark Brown @ 2015-06-09 18:09 UTC (permalink / raw)
To: kernel-build-reports, linaro-kernel, linux-next
Tree/Branch: next-20150609
Git describe: next-20150609
Commit: b47ecb252f Add linux-next specific files for 20150609
Build Time: 66 min 22 sec
Passed: 7 / 9 ( 77.78 %)
Failed: 2 / 9 ( 22.22 %)
Errors: 3
Warnings: 40
Section Mismatches: 2
Failed defconfigs:
arm64-allmodconfig
arm-allmodconfig
Errors:
arm64-allmodconfig
ERROR: "acpi_gpiochip_request_interrupts" [drivers/gpio/gpio-xgene-sb.ko] undefined!
ERROR: "acpi_gpiochip_free_interrupts" [drivers/gpio/gpio-xgene-sb.ko] undefined!
arm-allmodconfig
ERROR: "__aeabi_uldivmod" [drivers/media/pci/cobalt/cobalt.ko] undefined!
-------------------------------------------------------------------------------
defconfigs with issues (other than build errors):
2 warnings 0 mismatches : arm64-allnoconfig
17 warnings 3 mismatches : arm64-allmodconfig
5 warnings 0 mismatches : arm-multi_v5_defconfig
8 warnings 0 mismatches : arm-multi_v7_defconfig
3 warnings 0 mismatches : x86_64-defconfig
16 warnings 0 mismatches : arm-allmodconfig
1 warnings 0 mismatches : arm-allnoconfig
5 warnings 0 mismatches : arm64-defconfig
-------------------------------------------------------------------------------
Errors summary: 3
1 ERROR: "acpi_gpiochip_request_interrupts" [drivers/gpio/gpio-xgene-sb.ko] undefined!
1 ERROR: "acpi_gpiochip_free_interrupts" [drivers/gpio/gpio-xgene-sb.ko] undefined!
1 ERROR: "__aeabi_uldivmod" [drivers/media/pci/cobalt/cobalt.ko] undefined!
Warnings Summary: 40
10 <stdin>:1253:2: warning: #warning syscall userfaultfd not implemented [-Wcpp]
5 ../crypto/jitterentropy.c:266:9: warning: #pragma GCC target is not supported for this machine [-Wpragmas]
4 ../block/cfq-iosched.c:469:2: warning: 'cpd_to_cfqgd' defined but not used [-Wunused-function]
2 ../crypto/jitterentropy.c:336:9: warning: #pragma GCC target is not supported for this machine [-Wpragmas]
1 arch/arm/configs/multi_v7_defconfig:605:warning: override: reassigning to symbol COMMON_CLK_QCOM
1 ../sound/soc/samsung/dmaengine.c:60:31: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
1 ../sound/soc/samsung/dmaengine.c:53:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
1 ../net/ipv4/inet_hashtables.c:631:13: warning: division by zero [-Wdiv-by-zero]
1 ../net/bluetooth/mgmt.c:6463:8: warning: 'r192' may be used uninitialized in this function [-Wmaybe-uninitialized]
1 ../net/bluetooth/mgmt.c:6463:8: warning: 'h192' may be used uninitialized in this function [-Wmaybe-uninitialized]
1 ../kernel/cgroup.c:2714:6: warning: 'ssid' may be used uninitialized in this function [-Wuninitialized]
1 ../include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer implicitly truncated to unsigned type [-Woverflow]
1 ../include/trace/trace_events.h:28:0: warning: "TRACE_SYSTEM_STRING" redefined [enabled by default]
1 ../include/linux/dynamic_debug.h:64:16: warning: format '%u' expects argument of type 'unsigned int', but argument 6 has type 'size_t' [-Wformat=]
1 ../include/linux/bitops.h:6:19: warning: large integer implicitly truncated to unsigned type [-Woverflow]
1 ../drivers/usb/renesas_usbhs/common.c:496:25: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
1 ../drivers/scsi/advansys.c:7805:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]
1 ../drivers/rtc/rtc-armada38x.c:91:22: warning: unused variable 'flags' [-Wunused-variable]
1 ../drivers/net/ethernet/dec/tulip/winbond-840.c:910:2: warning: #warning Processor architecture undefined [-Wcpp]
1 ../drivers/net/ethernet/dec/tulip/tulip_core.c:101:2: warning: #warning Processor architecture undefined! [-Wcpp]
1 ../drivers/mmc/host/sh_mmcif.c:418:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
1 ../drivers/mmc/host/sh_mmcif.c:417:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
1 ../drivers/media/platform/coda/./trace.h:12:0: warning: "TRACE_SYSTEM_STRING" redefined [enabled by default]
1 ../drivers/infiniband/hw/qib/qib_qp.c:44:0: warning: "BITS_PER_PAGE" redefined
1 ../drivers/infiniband/hw/cxgb4/mem.c:147:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
1 ../drivers/gpu/drm/virtio/virtgpu_fence.c:64:2: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'long long int' [-Wformat]
1 ../drivers/gpu/drm/virtio/virtgpu_debugfs.c:39:6: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'long long int' [-Wformat]
1 ../drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm204.c:975:1: warning: the frame size of 1208 bytes is larger than 1024 bytes [-Wframe-larger-than=]
1 ../drivers/gpu/drm/i915/intel_display.c:11877:6: warning: 'crtc' may be used uninitialized in this function [-Wmaybe-uninitialized]
1 ../drivers/gpu/drm/i915/intel_display.c:11853:14: warning: 'crtc_state' may be used uninitialized in this function [-Wmaybe-uninitialized]
1 ../drivers/gpu/drm/exynos/exynos_drm_vidi.c:183:6: warning: unused variable 'i' [-Wunused-variable]
1 ../drivers/gpu/drm/exynos/exynos_drm_vidi.c:182:27: warning: unused variable 'plane' [-Wunused-variable]
1 ../drivers/gpio/gpio-74xx-mmio.c:132:16: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
1 ../drivers/block/nvme-core.c:1834:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
1 ../drivers/block/nvme-core.c:1792:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
1 ../drivers/block/drbd/drbd_bitmap.c:483:0: warning: "BITS_PER_PAGE_MASK" redefined
1 ../drivers/block/drbd/drbd_bitmap.c:482:0: warning: "BITS_PER_PAGE" redefined
1 ../crypto/wp512.c:987:1: warning: the frame size of 1112 bytes is larger than 1024 bytes [-Wframe-larger-than=]
1 ../arch/arm64/kernel/psci.c:61:13: warning: 'psci_tos_resident_on' defined but not used [-Wunused-function]
1 ../arch/arm/mach-cns3xxx/pcie.c:266:1: warning: the frame size of 1088 bytes is larger than 1024 bytes [-Wframe-larger-than=]
Section Mismatch Summary: 2
2 WARNING: drivers/staging/fsl-mc/bus/mc-bus-driver.o(.init.text+0x18c): Section mismatch in reference from the function init_module() to the function .exit.text:dprc_driver_exit()
1 WARNING: drivers/i2c/busses/i2c-xgene-slimpro.o(.data+0x28): Section mismatch in reference from the variable xgene_slimpro_i2c_driver to the variable .init.text:$x
===============================================================================
Detailed per-defconfig build reports below:
-------------------------------------------------------------------------------
arm64-allnoconfig : PASS, 0 errors, 2 warnings, 0 section mismatches
Warnings:
<stdin>:1253:2: warning: #warning syscall userfaultfd not implemented [-Wcpp]
../arch/arm64/kernel/psci.c:61:13: warning: 'psci_tos_resident_on' defined but not used [-Wunused-function]
-------------------------------------------------------------------------------
arm64-allmodconfig : FAIL, 2 errors, 17 warnings, 3 section mismatches
Errors:
ERROR: "acpi_gpiochip_request_interrupts" [drivers/gpio/gpio-xgene-sb.ko] undefined!
ERROR: "acpi_gpiochip_free_interrupts" [drivers/gpio/gpio-xgene-sb.ko] undefined!
Warnings:
<stdin>:1253:2: warning: #warning syscall userfaultfd not implemented [-Wcpp]
../crypto/jitterentropy.c:266:9: warning: #pragma GCC target is not supported for this machine [-Wpragmas]
../crypto/jitterentropy.c:336:9: warning: #pragma GCC target is not supported for this machine [-Wpragmas]
../drivers/block/drbd/drbd_bitmap.c:482:0: warning: "BITS_PER_PAGE" redefined
../drivers/block/drbd/drbd_bitmap.c:483:0: warning: "BITS_PER_PAGE_MASK" redefined
../include/linux/dynamic_debug.h:64:16: warning: format '%u' expects argument of type 'unsigned int', but argument 6 has type 'size_t' [-Wformat=]
../drivers/gpio/gpio-74xx-mmio.c:132:16: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
../sound/soc/samsung/dmaengine.c:53:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
../sound/soc/samsung/dmaengine.c:60:31: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
../drivers/infiniband/hw/qib/qib_qp.c:44:0: warning: "BITS_PER_PAGE" redefined
../drivers/mmc/host/sh_mmcif.c:417:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
../drivers/mmc/host/sh_mmcif.c:418:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
../drivers/net/ethernet/dec/tulip/winbond-840.c:910:2: warning: #warning Processor architecture undefined [-Wcpp]
../drivers/net/ethernet/dec/tulip/tulip_core.c:101:2: warning: #warning Processor architecture undefined! [-Wcpp]
../include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer implicitly truncated to unsigned type [-Woverflow]
../include/linux/bitops.h:6:19: warning: large integer implicitly truncated to unsigned type [-Woverflow]
../drivers/usb/renesas_usbhs/common.c:496:25: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
Section Mismatches:
WARNING: drivers/staging/fsl-mc/bus/mc-bus-driver.o(.init.text+0x18c): Section mismatch in reference from the function init_module() to the function .exit.text:dprc_driver_exit()
WARNING: drivers/i2c/busses/i2c-xgene-slimpro.o(.data+0x28): Section mismatch in reference from the variable xgene_slimpro_i2c_driver to the variable .init.text:$x
WARNING: drivers/staging/fsl-mc/bus/mc-bus-driver.o(.init.text+0x18c): Section mismatch in reference from the function init_module() to the function .exit.text:dprc_driver_exit()
-------------------------------------------------------------------------------
arm-multi_v5_defconfig : PASS, 0 errors, 5 warnings, 0 section mismatches
Warnings:
<stdin>:1253:2: warning: #warning syscall userfaultfd not implemented [-Wcpp]
../crypto/jitterentropy.c:266:9: warning: #pragma GCC target is not supported for this machine [-Wpragmas]
../block/cfq-iosched.c:469:2: warning: 'cpd_to_cfqgd' defined but not used [-Wunused-function]
../net/ipv4/inet_hashtables.c:631:13: warning: division by zero [-Wdiv-by-zero]
<stdin>:1253:2: warning: #warning syscall userfaultfd not implemented [-Wcpp]
-------------------------------------------------------------------------------
arm-multi_v7_defconfig : PASS, 0 errors, 8 warnings, 0 section mismatches
Warnings:
arch/arm/configs/multi_v7_defconfig:605:warning: override: reassigning to symbol COMMON_CLK_QCOM
<stdin>:1253:2: warning: #warning syscall userfaultfd not implemented [-Wcpp]
../block/cfq-iosched.c:469:2: warning: 'cpd_to_cfqgd' defined but not used [-Wunused-function]
../crypto/jitterentropy.c:266:9: warning: #pragma GCC target is not supported for this machine [-Wpragmas]
../net/bluetooth/mgmt.c:6463:8: warning: 'r192' may be used uninitialized in this function [-Wmaybe-uninitialized]
../net/bluetooth/mgmt.c:6463:8: warning: 'h192' may be used uninitialized in this function [-Wmaybe-uninitialized]
../kernel/cgroup.c:2714:6: warning: 'ssid' may be used uninitialized in this function [-Wuninitialized]
<stdin>:1253:2: warning: #warning syscall userfaultfd not implemented [-Wcpp]
-------------------------------------------------------------------------------
x86_64-defconfig : PASS, 0 errors, 3 warnings, 0 section mismatches
Warnings:
../block/cfq-iosched.c:469:2: warning: 'cpd_to_cfqgd' defined but not used [-Wunused-function]
../drivers/gpu/drm/i915/intel_display.c:11853:14: warning: 'crtc_state' may be used uninitialized in this function [-Wmaybe-uninitialized]
../drivers/gpu/drm/i915/intel_display.c:11877:6: warning: 'crtc' may be used uninitialized in this function [-Wmaybe-uninitialized]
-------------------------------------------------------------------------------
arm-allmodconfig : FAIL, 1 errors, 16 warnings, 0 section mismatches
Errors:
ERROR: "__aeabi_uldivmod" [drivers/media/pci/cobalt/cobalt.ko] undefined!
Warnings:
<stdin>:1253:2: warning: #warning syscall userfaultfd not implemented [-Wcpp]
../arch/arm/mach-cns3xxx/pcie.c:266:1: warning: the frame size of 1088 bytes is larger than 1024 bytes [-Wframe-larger-than=]
../crypto/wp512.c:987:1: warning: the frame size of 1112 bytes is larger than 1024 bytes [-Wframe-larger-than=]
../crypto/jitterentropy.c:266:9: warning: #pragma GCC target is not supported for this machine [-Wpragmas]
../drivers/block/nvme-core.c:1792:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
../drivers/block/nvme-core.c:1834:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
../drivers/gpu/drm/exynos/exynos_drm_vidi.c:183:6: warning: unused variable 'i' [-Wunused-variable]
../drivers/gpu/drm/exynos/exynos_drm_vidi.c:182:27: warning: unused variable 'plane' [-Wunused-variable]
../drivers/gpu/drm/virtio/virtgpu_fence.c:64:2: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'long long int' [-Wformat]
../drivers/gpu/drm/virtio/virtgpu_debugfs.c:39:6: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'long long int' [-Wformat]
../drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm204.c:975:1: warning: the frame size of 1208 bytes is larger than 1024 bytes [-Wframe-larger-than=]
../drivers/infiniband/hw/cxgb4/mem.c:147:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
../include/trace/trace_events.h:28:0: warning: "TRACE_SYSTEM_STRING" redefined [enabled by default]
../drivers/media/platform/coda/./trace.h:12:0: warning: "TRACE_SYSTEM_STRING" redefined [enabled by default]
../drivers/rtc/rtc-armada38x.c:91:22: warning: unused variable 'flags' [-Wunused-variable]
../drivers/scsi/advansys.c:7805:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]
-------------------------------------------------------------------------------
arm-allnoconfig : PASS, 0 errors, 1 warnings, 0 section mismatches
Warnings:
<stdin>:1253:2: warning: #warning syscall userfaultfd not implemented [-Wcpp]
-------------------------------------------------------------------------------
arm64-defconfig : PASS, 0 errors, 5 warnings, 0 section mismatches
Warnings:
<stdin>:1253:2: warning: #warning syscall userfaultfd not implemented [-Wcpp]
../crypto/jitterentropy.c:266:9: warning: #pragma GCC target is not supported for this machine [-Wpragmas]
../crypto/jitterentropy.c:336:9: warning: #pragma GCC target is not supported for this machine [-Wpragmas]
../block/cfq-iosched.c:469:2: warning: 'cpd_to_cfqgd' defined but not used [-Wunused-function]
<stdin>:1253:2: warning: #warning syscall userfaultfd not implemented [-Wcpp]
-------------------------------------------------------------------------------
Passed with no errors, warnings or mismatches:
x86_64-allnoconfig
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: next-20150609 build: 2 failures 40 warnings (next-20150609)
2015-06-09 18:09 next-20150609 build: 2 failures 40 warnings (next-20150609) Build bot for Mark Brown
@ 2015-06-09 18:23 ` Mark Brown
2015-06-10 7:33 ` [Linaro-acpi] " Hanjun Guo
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2015-06-09 18:23 UTC (permalink / raw)
To: Y Vo, Linus Walleij
Cc: kernel-build-reports, linaro-kernel, linux-next, linaro-acpi
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
On Tue, Jun 09, 2015 at 07:09:47PM +0100, Build bot for Mark Brown wrote:
> arm64-allmodconfig
> ERROR: "acpi_gpiochip_request_interrupts" [drivers/gpio/gpio-xgene-sb.ko] undefined!
> ERROR: "acpi_gpiochip_free_interrupts" [drivers/gpio/gpio-xgene-sb.ko] undefined!
Today's -next fails to build an arm64 allmodconfig due to commit
733cf014f02040b3ad (gpio: xgene: add ACPI support for APM X-Gene GPIO
standby driver) which adds ACPI support to the X-Gene standby driver
without either adding a dependency on ACPI or there being stubs in the
ACPI headers for the above functions in !ACPI configurations. My
instinct is that the stubs are going to be nicer since it'll save on
ifdefs in drivers which seems nicer.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Linaro-acpi] next-20150609 build: 2 failures 40 warnings (next-20150609)
2015-06-09 18:23 ` Mark Brown
@ 2015-06-10 7:33 ` Hanjun Guo
2015-06-10 8:43 ` Y Vo
0 siblings, 1 reply; 5+ messages in thread
From: Hanjun Guo @ 2015-06-10 7:33 UTC (permalink / raw)
To: Mark Brown, Y Vo, Linus Walleij
Cc: linaro-acpi, linaro-kernel, linux-next, kernel-build-reports
On 06/10/2015 02:23 AM, Mark Brown wrote:
> On Tue, Jun 09, 2015 at 07:09:47PM +0100, Build bot for Mark Brown wrote:
>
>> arm64-allmodconfig
>> ERROR: "acpi_gpiochip_request_interrupts" [drivers/gpio/gpio-xgene-sb.ko] undefined!
>> ERROR: "acpi_gpiochip_free_interrupts" [drivers/gpio/gpio-xgene-sb.ko] undefined!
>
> Today's -next fails to build an arm64 allmodconfig due to commit
> 733cf014f02040b3ad (gpio: xgene: add ACPI support for APM X-Gene GPIO
> standby driver) which adds ACPI support to the X-Gene standby driver
> without either adding a dependency on ACPI or there being stubs in the
> ACPI headers for the above functions in !ACPI configurations. My
> instinct is that the stubs are going to be nicer since it'll save on
> ifdefs in drivers which seems nicer.
It seems that acpi_gpiochip_request_interrupts didn't export
so there will be a compile error when xgene-sb compiled as
a ko, I prepared a patch below:
From d47771429144d80a2c38b79f06577dd237e349d1 Mon Sep 17 00:00:00 2001
From: Hanjun Guo <hanjun.guo@linaro.org>
Date: Wed, 10 Jun 2015 15:24:30 +0800
Subject: [PATCH] GPIO / ACPI: export acpi_gpiochip_request(free)_interrupts
for module use
acpi_gpiochip_request(free)_interrupts can be used for modules,
so export them. This also fixs a compile error when xgene-sb
configured as kernel module.
Fixes: 733cf014f020 "gpio: xgene: add ACPI support for APM X-Gene GPIO
standby driver"
Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
---
drivers/gpio/gpiolib-acpi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index 19b99d0..980a996 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -307,6 +307,7 @@ void acpi_gpiochip_request_interrupts(struct
gpio_chip *chip)
acpi_walk_resources(handle, "_AEI",
acpi_gpiochip_request_interrupt, acpi_gpio);
}
+EXPORT_SYMBOL_GPL(acpi_gpiochip_request_interrupts);
/**
* acpi_gpiochip_free_interrupts() - Free GPIO ACPI event interrupts.
@@ -346,6 +347,7 @@ void acpi_gpiochip_free_interrupts(struct gpio_chip
*chip)
kfree(event);
}
}
+EXPORT_SYMBOL_GPL(acpi_gpiochip_free_interrupts);
int acpi_dev_add_driver_gpios(struct acpi_device *adev,
const struct acpi_gpio_mapping *gpios)
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Linaro-acpi] next-20150609 build: 2 failures 40 warnings (next-20150609)
2015-06-10 7:33 ` [Linaro-acpi] " Hanjun Guo
@ 2015-06-10 8:43 ` Y Vo
2015-06-10 9:02 ` Hanjun Guo
0 siblings, 1 reply; 5+ messages in thread
From: Y Vo @ 2015-06-10 8:43 UTC (permalink / raw)
To: Hanjun Guo
Cc: Mark Brown, Linus Walleij, linaro-acpi, linaro-kernel, linux-next,
kernel-build-reports
On Wed, Jun 10, 2015 at 2:33 PM, Hanjun Guo <hanjun.guo@linaro.org> wrote:
> On 06/10/2015 02:23 AM, Mark Brown wrote:
>>
>> On Tue, Jun 09, 2015 at 07:09:47PM +0100, Build bot for Mark Brown wrote:
>>
>>> arm64-allmodconfig
>>> ERROR: "acpi_gpiochip_request_interrupts" [drivers/gpio/gpio-xgene-sb.ko]
>>> undefined!
>>> ERROR: "acpi_gpiochip_free_interrupts" [drivers/gpio/gpio-xgene-sb.ko]
>>> undefined!
>>
>>
>> Today's -next fails to build an arm64 allmodconfig due to commit
>> 733cf014f02040b3ad (gpio: xgene: add ACPI support for APM X-Gene GPIO
>> standby driver) which adds ACPI support to the X-Gene standby driver
>> without either adding a dependency on ACPI or there being stubs in the
>> ACPI headers for the above functions in !ACPI configurations. My
>> instinct is that the stubs are going to be nicer since it'll save on
>> ifdefs in drivers which seems nicer.
>
>
> It seems that acpi_gpiochip_request_interrupts didn't export
> so there will be a compile error when xgene-sb compiled as
> a ko, I prepared a patch below:
Coud you help to submit this patch ?
>
>
> From d47771429144d80a2c38b79f06577dd237e349d1 Mon Sep 17 00:00:00 2001
> From: Hanjun Guo <hanjun.guo@linaro.org>
> Date: Wed, 10 Jun 2015 15:24:30 +0800
> Subject: [PATCH] GPIO / ACPI: export acpi_gpiochip_request(free)_interrupts
> for module use
>
> acpi_gpiochip_request(free)_interrupts can be used for modules,
> so export them. This also fixs a compile error when xgene-sb
> configured as kernel module.
>
> Fixes: 733cf014f020 "gpio: xgene: add ACPI support for APM X-Gene GPIO
> standby driver"
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> ---
> drivers/gpio/gpiolib-acpi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> index 19b99d0..980a996 100644
> --- a/drivers/gpio/gpiolib-acpi.c
> +++ b/drivers/gpio/gpiolib-acpi.c
> @@ -307,6 +307,7 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip
> *chip)
> acpi_walk_resources(handle, "_AEI",
> acpi_gpiochip_request_interrupt, acpi_gpio);
> }
> +EXPORT_SYMBOL_GPL(acpi_gpiochip_request_interrupts);
>
> /**
> * acpi_gpiochip_free_interrupts() - Free GPIO ACPI event interrupts.
> @@ -346,6 +347,7 @@ void acpi_gpiochip_free_interrupts(struct gpio_chip
> *chip)
> kfree(event);
> }
> }
> +EXPORT_SYMBOL_GPL(acpi_gpiochip_free_interrupts);
>
> int acpi_dev_add_driver_gpios(struct acpi_device *adev,
> const struct acpi_gpio_mapping *gpios)
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Linaro-acpi] next-20150609 build: 2 failures 40 warnings (next-20150609)
2015-06-10 8:43 ` Y Vo
@ 2015-06-10 9:02 ` Hanjun Guo
0 siblings, 0 replies; 5+ messages in thread
From: Hanjun Guo @ 2015-06-10 9:02 UTC (permalink / raw)
To: Y Vo
Cc: Mark Brown, Linus Walleij, linaro-acpi, linaro-kernel, linux-next,
kernel-build-reports
On 06/10/2015 04:43 PM, Y Vo wrote:
> On Wed, Jun 10, 2015 at 2:33 PM, Hanjun Guo <hanjun.guo@linaro.org> wrote:
>> On 06/10/2015 02:23 AM, Mark Brown wrote:
>>>
>>> On Tue, Jun 09, 2015 at 07:09:47PM +0100, Build bot for Mark Brown wrote:
>>>
>>>> arm64-allmodconfig
>>>> ERROR: "acpi_gpiochip_request_interrupts" [drivers/gpio/gpio-xgene-sb.ko]
>>>> undefined!
>>>> ERROR: "acpi_gpiochip_free_interrupts" [drivers/gpio/gpio-xgene-sb.ko]
>>>> undefined!
>>>
>>>
>>> Today's -next fails to build an arm64 allmodconfig due to commit
>>> 733cf014f02040b3ad (gpio: xgene: add ACPI support for APM X-Gene GPIO
>>> standby driver) which adds ACPI support to the X-Gene standby driver
>>> without either adding a dependency on ACPI or there being stubs in the
>>> ACPI headers for the above functions in !ACPI configurations. My
>>> instinct is that the stubs are going to be nicer since it'll save on
>>> ifdefs in drivers which seems nicer.
>>
>>
>> It seems that acpi_gpiochip_request_interrupts didn't export
>> so there will be a compile error when xgene-sb compiled as
>> a ko, I prepared a patch below:
>
> Coud you help to submit this patch ?
No problem, will do it right now.
Thanks
Hanjun
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-10 9:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-09 18:09 next-20150609 build: 2 failures 40 warnings (next-20150609) Build bot for Mark Brown
2015-06-09 18:23 ` Mark Brown
2015-06-10 7:33 ` [Linaro-acpi] " Hanjun Guo
2015-06-10 8:43 ` Y Vo
2015-06-10 9:02 ` Hanjun Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).