Re: linux-next: Tree for Aug 17 (staging/hfi1)

[Randy Dunlap <rdunlap@infradead.org>]

On 08/17/15 03:55, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20150813:
> 


Several items:

A:  these and other similar errors:

In file included from ../drivers/staging/hfi1/chip.c:61:0:
../drivers/staging/hfi1/chip.c: In function ‘__hfi1_trace_LINKVERB’:
../drivers/staging/hfi1/trace.h:1357:20: error: function ‘__hfi1_trace_LINKVERB’ can never be inlined because it uses variable argument lists
 static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
                    ^
../drivers/staging/hfi1/chip.c: In function ‘__hfi1_trace_CNTR’:
../drivers/staging/hfi1/trace.h:1357:20: error: function ‘__hfi1_trace_CNTR’ can never be inlined because it uses variable argument lists
 static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
                    ^
../drivers/staging/hfi1/chip.c: In function ‘__hfi1_trace_DC8051’:
../drivers/staging/hfi1/trace.h:1357:20: error: function ‘__hfi1_trace_DC8051’ can never be inlined because it uses variable argument lists
 static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
                    ^
../drivers/staging/hfi1/chip.c: In function ‘__hfi1_trace_RCVCTRL’:
../drivers/staging/hfi1/trace.h:1357:20: error: function ‘__hfi1_trace_RCVCTRL’ can never be inlined because it uses variable argument lists
 static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
                    ^
../drivers/staging/hfi1/chip.c: In function ‘__hfi1_trace_TID’:
../drivers/staging/hfi1/trace.h:1357:20: error: function ‘__hfi1_trace_TID’ can never be inlined because it uses variable argument lists
 static inline void __hfi1_trace_##fn(const char *func, char *fmt, ...) \
                    ^

B:  When CONFIG_PCI is not enabled, lots of these errors:

In file included from ../drivers/staging/hfi1/chip.c:60:0:
../drivers/staging/hfi1/hfi.h:508:20: error: field ‘msix’ has incomplete type
  struct msix_entry msix;
                   ^

../drivers/staging/hfi1/chip.c: In function ‘disable_intx’:
../drivers/staging/hfi1/chip.c:8667:2: error: implicit declaration of function ‘pci_intx’ [-Werror=implicit-function-declaration]
  pci_intx(pdev, 0);
  ^

so the driver should depend on PCI or maybe even PCI_MSI.

C.  Please provide some contact info, e.g. in a TODO file or the MAINTAINERS file.


-- 
~Randy