From: Arnd Bergmann <arnd@arndb.de>
To: Borislav Petkov <bp@alien8.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Borislav Petkov <borislav.petkov@amd.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Loc Ho <lho@apm.com>
Subject: Re: linux-next: build failure after merge of the edac-amd tree
Date: Mon, 01 Jun 2015 16:36:20 +0200 [thread overview]
Message-ID: <5689037.BqsIAc2Shz@wuerfel> (raw)
In-Reply-To: <20150601095127.GA21881@pd.tnic>
On Monday 01 June 2015 11:51:27 Borislav Petkov wrote:
> On Mon, Jun 01, 2015 at 05:07:42PM +1000, Stephen Rothwell wrote:
> > Hi Borislav,
> >
> > After merging the edac-amd tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/edac/xgene_edac.c: In function 'xgene_edac_pmd_l2c_version1':
> > drivers/edac/xgene_edac.c:792:2: error: implicit declaration of function 'MIDR_VARIANT' [-Werror=implicit-function-declaration]
> > switch (MIDR_VARIANT(read_cpuid_id())) {
> > ^
> > drivers/edac/xgene_edac.c:792:2: error: implicit declaration of function 'read_cpuid_id' [-Werror=implicit-function-declaration]
> > drivers/edac/xgene_edac.c:794:3: error: implicit declaration of function 'MIDR_REVISION' [-Werror=implicit-function-declaration]
> > switch (MIDR_REVISION(read_cpuid_id())) {
> > ^
> > drivers/edac/xgene_edac.c:797:4: error: implicit declaration of function 'read_cpuid' [-Werror=implicit-function-declaration]
> > switch (REVIDR_MINOR_REV(read_cpuid(REVIDR_EL1))) {
> > ^
> > drivers/edac/xgene_edac.c:797:40: error: 'REVIDR_EL1' undeclared (first use in this function)
> > switch (REVIDR_MINOR_REV(read_cpuid(REVIDR_EL1))) {
> > ^
> > drivers/edac/xgene_edac.c:790:37: note: in definition of macro 'REVIDR_MINOR_REV'
> > #define REVIDR_MINOR_REV(revidr) ((revidr) & 0x00000007)
> > ^
> > drivers/edac/xgene_edac.c:797:40: note: each undeclared identifier is reported only once for each function it appears in
> > switch (REVIDR_MINOR_REV(read_cpuid(REVIDR_EL1))) {
> > ^
> > drivers/edac/xgene_edac.c:790:37: note: in definition of macro 'REVIDR_MINOR_REV'
> > #define REVIDR_MINOR_REV(revidr) ((revidr) & 0x00000007)
> > ^
> >
> > Caused by commit ("EDAC: Add APM X-Gene SoC EDAC driver"). You can't
> > use COMPIlE_TEST for drivers that use arch specific APIs ...
>
> Yeah, the COMPIlE_TEST thing was not such a good idea, after all.
>
At least it should have been tested.
Can we instead just kill the CPUID check? It has absolutely no business
in a device driver like this, and the driver should be made to build
fine on all architectures.
Arnd
prev parent reply other threads:[~2015-06-01 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 7:07 linux-next: build failure after merge of the edac-amd tree Stephen Rothwell
2015-06-01 9:51 ` Borislav Petkov
2015-06-01 14:36 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5689037.BqsIAc2Shz@wuerfel \
--to=arnd@arndb.de \
--cc=borislav.petkov@amd.com \
--cc=bp@alien8.de \
--cc=lho@apm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox