From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Pratap Nirujogi <pratap.nirujogi@amd.com>, andi.shyti@kernel.org
Cc: rdunlap@infradead.org, Hans de Goede <hdegoede@redhat.com>,
sfr@canb.auug.org.au, linux-next@vger.kernel.org,
linux-i2c@vger.kernel.org, platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
benjamin.chan@amd.com, bin.du@amd.com,
gjorgji.rosikopulos@amd.com, king.li@amd.com, dantony@amd.com
Subject: Re: [PATCH v4 3/3] platform/x86: Use i2c adapter name to fix build errors
Date: Tue, 10 Jun 2025 11:42:00 +0300 (EEST) [thread overview]
Message-ID: <570c7765-b3bc-77cd-dddb-d19e85611114@linux.intel.com> (raw)
In-Reply-To: <20250609155601.1477055-4-pratap.nirujogi@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1627 bytes --]
On Mon, 9 Jun 2025, Pratap Nirujogi wrote:
> Use adapater->name inplace of adapter->owner->name to fix
> build issues when CONFIG_MODULES is not defined.
>
> Fixes: 90b85567e457 ("platform/x86: Add AMD ISP platform config for OV05C10")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Link: https://lore.kernel.org/all/04577a46-9add-420c-b181-29bad582026d@infradead.org
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Pratap Nirujogi <pratap.nirujogi@amd.com>
> ---
> drivers/platform/x86/amd/amd_isp4.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/amd/amd_isp4.c b/drivers/platform/x86/amd/amd_isp4.c
> index 0cc01441bcbb..9f291aeb35f1 100644
> --- a/drivers/platform/x86/amd/amd_isp4.c
> +++ b/drivers/platform/x86/amd/amd_isp4.c
> @@ -11,6 +11,7 @@
> #include <linux/mutex.h>
> #include <linux/platform_device.h>
> #include <linux/property.h>
> +#include <linux/soc/amd/isp4_misc.h>
> #include <linux/string.h>
> #include <linux/types.h>
> #include <linux/units.h>
> @@ -151,7 +152,7 @@ MODULE_DEVICE_TABLE(acpi, amdisp_sensor_ids);
>
> static inline bool is_isp_i2c_adapter(struct i2c_adapter *adap)
> {
> - return !strcmp(adap->owner->name, "i2c_designware_amdisp");
> + return !strcmp(adap->name, AMDISP_I2C_ADAP_NAME);
> }
>
> static void instantiate_isp_i2c_client(struct amdisp_platform *isp4_platform,
Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Andi, do you want to take this fix series through i2c tree or do you
prefer me to take them through pdx86 tree?
--
i.
next prev parent reply other threads:[~2025-06-10 8:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 15:53 [PATCH v4 0/3] Fix build issue when CONFIG_MODULES is not set Pratap Nirujogi
2025-06-09 15:53 ` [PATCH v4 1/3] i2c: designware: Initialize adapter name only when " Pratap Nirujogi
2025-06-09 15:53 ` [PATCH v4 2/3] i2c: amd-isp: Initialize unique adapter name Pratap Nirujogi
2025-06-09 15:53 ` [PATCH v4 3/3] platform/x86: Use i2c adapter name to fix build errors Pratap Nirujogi
2025-06-10 8:42 ` Ilpo Järvinen [this message]
2025-06-24 12:07 ` Ilpo Järvinen
2025-06-25 21:10 ` Andi Shyti
2025-06-25 21:43 ` [PATCH v4 0/3] Fix build issue when CONFIG_MODULES is not set Andi Shyti
2025-06-25 21:51 ` Nirujogi, Pratap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570c7765-b3bc-77cd-dddb-d19e85611114@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=benjamin.chan@amd.com \
--cc=bin.du@amd.com \
--cc=dantony@amd.com \
--cc=gjorgji.rosikopulos@amd.com \
--cc=hdegoede@redhat.com \
--cc=king.li@amd.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pratap.nirujogi@amd.com \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox