From: Timothy Pearson <tpearson@raptorengineering.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Alexey Kardashevskiy <aik@ozlabs.ru>
Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
Date: Sat, 3 Jun 2023 22:57:28 -0500 (CDT) [thread overview]
Message-ID: <586983120.3136676.1685851048873.JavaMail.zimbra@raptorengineeringinc.com> (raw)
In-Reply-To: <87h6rogjok.fsf@mail.lhotse>
----- Original Message -----
> From: "Michael Ellerman" <mpe@ellerman.id.au>
> To: "Randy Dunlap" <rdunlap@infradead.org>, "Stephen Rothwell" <sfr@canb.auug.org.au>, "Linux Next Mailing List"
> <linux-next@vger.kernel.org>
> Cc: "linux-kernel" <linux-kernel@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>, "Alexey
> Kardashevskiy" <aik@ozlabs.ru>, "Timothy Pearson" <tpearson@raptorengineering.com>
> Sent: Saturday, June 3, 2023 7:22:51 PM
> Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c)
> Randy Dunlap <rdunlap@infradead.org> writes:
>> On 6/1/23 21:01, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20230601:
>>>
>>
>> On powerpc64, a randconfig failed with:
>>
>> In file included from ../include/linux/list.h:5,
>> from ../include/linux/preempt.h:11,
>> from ../include/linux/spinlock.h:56,
>> from ../include/linux/mmzone.h:8,
>> from ../include/linux/gfp.h:7,
>> from ../include/linux/slab.h:15,
>> from ../arch/powerpc/kernel/iommu.c:15:
>> ../arch/powerpc/kernel/iommu.c: In function
>> 'spapr_tce_setup_phb_iommus_initcall':
>> ../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use
>> in this function); did you mean 'zonelist'?
>> 1391 | list_for_each_entry(hose, &hose_list, list_node) {
>> | ^~~~~~~~~
> ...
>
> hose_list is in pci-common.c which is built when PCI=y.
>
> PSERIES and POWERNV force PCI=y.
>
> But this config has neither:
>
> # CONFIG_PPC_POWERNV is not set
> # CONFIG_PPC_PSERIES is not set
> CONFIG_HAVE_PCI=y
> # CONFIG_PCI is not set
> # CONFIG_COMMON_CLK_RS9_PCIE is not set
>
>
> Probably the spapr_tce code should be wrapped in an #ifdef that is only
> enabled when POWERNV || PSERIES is enabled.
>
> cheers
Sounds reasonable, I was going to look into this further over the weekend. I can put together a patch for Monday if that works?
next prev parent reply other threads:[~2023-06-04 4:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 4:01 linux-next: Tree for Jun 2 Stephen Rothwell
2023-06-02 20:56 ` linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c) Randy Dunlap
2023-06-04 0:22 ` Michael Ellerman
2023-06-04 3:57 ` Timothy Pearson [this message]
2023-06-04 21:55 ` Randy Dunlap
2023-06-15 16:00 ` Randy Dunlap
2023-06-15 16:05 ` Timothy Pearson
2023-06-15 16:13 ` Randy Dunlap
2023-06-15 16:34 ` Randy Dunlap
2023-06-15 22:46 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=586983120.3136676.1685851048873.JavaMail.zimbra@raptorengineeringinc.com \
--to=tpearson@raptorengineering.com \
--cc=aik@ozlabs.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox