From: Bart Van Assche <bvanassche@acm.org>
To: Arun Easi <aeasi@marvell.com>,
Steven Rostedt <rostedt@goodmis.org>,
Martin Petersen <martin.petersen@oracle.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
James Bottomley <jejb@linux.ibm.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org,
GR-QLogic-Storage-Upstream@marvell.com
Subject: Re: [PATCH v2 1/1] tracing: Fix compile error in trace_array calls when TRACING is disabled
Date: Wed, 7 Sep 2022 12:27:33 -0700 [thread overview]
Message-ID: <60870376-3518-896b-7a6b-a4b9ea05264f@acm.org> (raw)
In-Reply-To: <20220907185745.14382-2-aeasi@marvell.com>
On 9/7/22 11:57, Arun Easi wrote:
> +#else /* CONFIG_TRACING */
> +static inline int register_ftrace_export(struct trace_export *export)
> +{
> + return -EINVAL;
> +}
> +static inline int unregister_ftrace_export(struct trace_export *export)
> +{
> + return 0;
> +}
Isn't it recommended to leave a blank line between function definitions?
> +static inline int
> +trace_array_printk(struct trace_array *tr, unsigned long ip,
> + const char *fmt, ...)
This is not the recommended way to format a function definition.
Consider running git clang-format HEAD^.
> +static inline struct trace_array *
> +trace_array_get_by_name(const char *name)
Same comment here.
Thanks,
Bart.
next prev parent reply other threads:[~2022-09-07 19:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 18:57 [PATCH v2 0/1] Tracing: Compile error with qla2xxx Arun Easi
2022-09-07 18:57 ` [PATCH v2 1/1] tracing: Fix compile error in trace_array calls when TRACING is disabled Arun Easi
2022-09-07 19:27 ` Bart Van Assche [this message]
2022-09-07 20:44 ` Steven Rostedt
2022-09-07 22:52 ` [EXT] " Arun Easi
2022-09-07 23:10 ` Arun Easi
2022-09-07 23:12 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60870376-3518-896b-7a6b-a4b9ea05264f@acm.org \
--to=bvanassche@acm.org \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=aeasi@marvell.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rostedt@goodmis.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox