From: Pankaj Gupta <pagupta@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Dan Williams <dan.j.williams@intel.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Yuval Shaia <yuval.shaia@oracle.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jakub Staron <jstaron@google.com>,
Cornelia Huck <cohuck@redhat.com>
Subject: Re: linux-next: build failure after merge of the nvdimm tree
Date: Fri, 5 Jul 2019 04:45:43 -0400 (EDT) [thread overview]
Message-ID: <616554090.39241752.1562316343431.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20190705172025.46abf71e@canb.auug.org.au>
Hi Stephen,
>
> Hi all,
>
> After merging the nvdimm tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from :32:
> ./usr/include/linux/virtio_pmem.h:19:2: error: unknown type name 'uint64_t'
> uint64_t start;
> ^~~~~~~~
> ./usr/include/linux/virtio_pmem.h:20:2: error: unknown type name 'uint64_t'
> uint64_t size;
> ^~~~~~~~
>
> Caused by commit
>
> 403b7f973855 ("virtio-pmem: Add virtio pmem driver")
>
> I have used the nvdimm tree from next-20190704 for today.
Thank you for the report.
Can we apply below patch [1] on top to complete linux-next build for today.
I have tested this locally.
Thanks,
Pankaj
========
[1]
diff --git a/drivers/nvdimm/virtio_pmem.h b/drivers/nvdimm/virtio_pmem.h
index 998efbc7660c..dbc12dfe8067 100644
--- a/drivers/nvdimm/virtio_pmem.h
+++ b/drivers/nvdimm/virtio_pmem.h
@@ -46,8 +46,8 @@ struct virtio_pmem {
spinlock_t pmem_lock;
/* Memory region information */
- uint64_t start;
- uint64_t size;
+ u64 start;
+ u64 size;
};
void virtio_pmem_host_ack(struct virtqueue *vq);
diff --git a/include/uapi/linux/virtio_pmem.h b/include/uapi/linux/virtio_pmem.h
index 379861f114f1..efcd72f2d20d 100644
--- a/include/uapi/linux/virtio_pmem.h
+++ b/include/uapi/linux/virtio_pmem.h
@@ -11,25 +11,24 @@
#define _UAPI_LINUX_VIRTIO_PMEM_H
#include <linux/types.h>
-#include <linux/virtio_types.h>
#include <linux/virtio_ids.h>
#include <linux/virtio_config.h>
struct virtio_pmem_config {
- uint64_t start;
- uint64_t size;
+ __u64 start;
+ __u64 size;
};
#define VIRTIO_PMEM_REQ_TYPE_FLUSH 0
struct virtio_pmem_resp {
/* Host return status corresponding to flush request */
- __virtio32 ret;
+ __u32 ret;
};
struct virtio_pmem_req {
/* command type */
- __virtio32 type;
+ __u32 type;
};
next prev parent reply other threads:[~2019-07-05 8:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 7:20 linux-next: build failure after merge of the nvdimm tree Stephen Rothwell
2019-07-05 8:45 ` Pankaj Gupta [this message]
2019-07-05 11:09 ` Stephen Rothwell
2019-07-05 11:14 ` Pankaj Gupta
2019-07-05 22:32 ` Dan Williams
2019-07-05 23:48 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2022-05-16 9:10 Stephen Rothwell
2022-05-16 18:05 ` Dan Williams
2021-08-30 7:09 Stephen Rothwell
2021-08-30 7:10 ` Christoph Hellwig
2021-08-30 7:15 ` Gao Xiang
2019-06-20 9:29 Stephen Rothwell
2019-06-20 10:30 ` Pankaj Gupta
2018-04-09 3:16 Stephen Rothwell
2018-04-09 3:38 ` Oliver
2018-04-09 7:34 ` Oliver
2018-04-09 17:11 ` Dan Williams
2018-04-09 18:14 ` Dan Williams
2017-11-03 7:19 Stephen Rothwell
2017-11-03 16:04 ` Dan Williams
2017-09-04 7:34 Stephen Rothwell
2017-09-04 18:34 ` Dan Williams
2017-04-24 6:11 Stephen Rothwell
2017-04-24 8:39 ` Al Viro
2017-04-24 23:29 ` Dan Williams
2017-04-25 22:22 ` Dan Williams
2016-07-22 6:13 Stephen Rothwell
2016-07-23 1:04 ` Dan Williams
2016-07-23 3:54 ` Dan Williams
2016-07-21 6:13 Stephen Rothwell
2016-07-21 21:33 ` Dan Williams
2016-03-27 9:50 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=616554090.39241752.1562316343431.JavaMail.zimbra@redhat.com \
--to=pagupta@redhat.com \
--cc=cohuck@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=jstaron@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sfr@canb.auug.org.au \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox