Re: + arch-m68k-include-asm-irqflagsh-fix-build.patch added to -mm tree

Re: + arch-m68k-include-asm-irqflagsh-fix-build.patch added to -mm tree

[Geert Uytterhoeven]

On Thu, Sep 23, 2010 at 00:01,  <akpm@linux-foundation.org> wrote:
>
> The patch titled
>     arch/m68k/include/asm/irqflags.h: fix build
> has been added to the -mm tree.  Its filename is
>     arch-m68k-include-asm-irqflagsh-fix-build.patch
>
> Before you just go and hit "reply", please:
>   a) Consider who else should be cc'ed
>   b) Prefer to cc a suitable mailing list as well
>   c) Ideally: find the original patch on the mailing list and do a
>      reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
> See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
> out what to do about this
>
> The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
>
> ------------------------------------------------------
> Subject: arch/m68k/include/asm/irqflags.h: fix build
> From: Andrew Morton <akpm@linux-foundation.org>
>
> arch/m68k/include/asm/irqflags.h: In function 'arch_local_irq_enable':
> arch/m68k/include/asm/irqflags.h:52: error: expected ';' before '}' token
>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thank you so much, Andrew!

David, can you please add this to irqflags/master?

> ---
>
>  arch/m68k/include/asm/irqflags.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN arch/m68k/include/asm/irqflags.h~arch-m68k-include-asm-irqflagsh-fix-build arch/m68k/include/asm/irqflags.h
> --- a/arch/m68k/include/asm/irqflags.h~arch-m68k-include-asm-irqflagsh-fix-build
> +++ a/arch/m68k/include/asm/irqflags.h
> @@ -47,7 +47,7 @@ static inline void arch_local_irq_enable
>                        "andiw %0,%%sr"
>                        :
>                        : "i" (ALLOWINT)
> -                       : "memory")
> +                       : "memory");
>  #endif
>  }

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: + arch-m68k-include-asm-irqflagsh-fix-build.patch added to -mm tree

[David Howells]

Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> David, can you please add this to irqflags/master?

Done.  It should appear on kernel.org shortly.

David