From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prarit Bhargava Subject: Re: [-next] system hangs likely due to "modules: Only return -EEXIST for modules that have finished loading" Date: Sat, 27 Apr 2019 06:42:51 -0400 Message-ID: <6a69074a-e913-3b67-feef-9b62a7400f8a@redhat.com> References: <20190426130736.GB8646@osiris> <20190426150741.GD8646@osiris> <20190426160956.GA3827@linux-8ccs> <2e047a7e-bf08-be8c-bdd0-429464fa133d@redhat.com> <52c293e9-ddfa-426a-a8f1-2106e250e78d@redhat.com> <20190427102440.GA28889@osiris> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190427102440.GA28889@osiris> Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org To: Heiko Carstens Cc: Jessica Yu , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Cathy Avery List-Id: linux-next.vger.kernel.org On 4/27/19 6:24 AM, Heiko Carstens wrote: > > diff --git a/kernel/module.c b/kernel/module.c > index 410eeb7e4f1d..48748cfec991 100644 > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -3585,6 +3585,7 @@ again: > finished_loading(mod->name)); > if (err) > goto out_unlocked; > + cond_resched(); > goto again; > } > err = -EEXIST; > Heiko, I'm testing on 2-cpu systems which appear to show the problem ~10% of the time. On another system I backed out my original patch to set a baseline, and noticed that occasionally the time to boot the system doubles from ~4 seconds to 9 seconds. Is this something you're also concerned with? P.