From mboxrd@z Thu Jan  1 00:00:00 1970
From: Philippe Proulx <philippe.proulx@savoirfairelinux.com>
Subject: Re: linux-next: build failure after merge of the tty tree
Date: Thu, 31 Oct 2013 09:09:51 -0400 (EDT)
Message-ID: <73605653.13929.1383224991870.JavaMail.root@mail>
References: <CA+icZUWYHSU3yvsW6fB5aKJ0LQVaY0afsF2DiS9=m_bzy80=hw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Return-path: <linux-serial-owner@vger.kernel.org>
In-Reply-To: <CA+icZUWYHSU3yvsW6fB5aKJ0LQVaY0afsF2DiS9=m_bzy80=hw@mail.gmail.com>
Sender: linux-serial-owner@vger.kernel.org
To: sedat dilek <sedat.dilek@gmail.com>
Cc: Greg KH <greg@kroah.com>, linux-next <linux-next@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, linux-serial@vger.kernel.org, Stephen Rothwell <sfr@canb.auug.org.au>
List-Id: linux-next.vger.kernel.org

----- Original Message -----
> From: "Sedat Dilek" <sedat.dilek@gmail.com>
> To: "Stephen Rothwell" <sfr@canb.auug.org.au>, "Philippe Proulx" <philippe.proulx@savoirfairelinux.com>
> Cc: "Greg KH" <greg@kroah.com>, "linux-next" <linux-next@vger.kernel.org>, "LKML" <linux-kernel@vger.kernel.org>,
> linux-serial@vger.kernel.org
> Sent: Thursday, 31 October, 2013 6:35:23 AM
> Subject: Re: linux-next: build failure after merge of the tty tree
> 
> On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
> > Hi Greg,
> >
> > After merging the tty tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe':
> > drivers/tty/serial/omap-serial.c:1724:22: error: expected ')'
> > before numeric constant
> > drivers/tty/serial/omap-serial.c:1724:22: warning: format '%d'
> > expects a matching 'int' argument [-Wformat]
> >
> > Caused by commit e5f9bf72efbc ("serial: omap: fix a few checkpatch
> > warnings").  There is a missing ',' in the dev_warn() ...
> >
> > I have used the version of the tty tree from next-20131030 for
> > today.
> >
> 
> [ Add CC to linux-serial ML ]
> 
> Happy HelloWien and WelcomeBackStephen!
> 
> That was only checkpatch-tested, eh :-)?
> 
> @@ -1724,8 +1722,9 @@ static int serial_omap_probe(struct
> platform_device *pdev)
> up->port.uartclk = omap_up_info->uartclk;
> if (!up->port.uartclk) {
> up->port.uartclk = DEFAULT_CLK_SPEED;
> - dev_warn(&pdev->dev, "No clock speed specified: using default:"
> - "%d\n", DEFAULT_CLK_SPEED);
> + dev_warn(&pdev->dev,
> + "No clock speed specified: using default: %d\n" <--- Comma missing
> here!

Oops, something obviously went wrong in my process. Sorry about this.

Do you want me to fix this commit?

> + DEFAULT_CLK_SPEED);
> }
> 
> - Sedat -
>